Commit7c058a3

authored and

committed

Remove dubious warning message from SQL/JSON functions

There was a warning that FORMAT JSON has no effect on json/jsonbtypes, which is true, but it's not clear why we should issue a warningabout it. The SQL standard does not say anything about this, whichshould generally govern the behavior here. So remove it.Discussion:https://www.postgresql.org/message-id/flat/dfec2cae-d17e-c508-6d16-c2dba82db486%40eisentraut.org

1 parent1b4be7d commit7c058a3Copy full SHA for 7c058a3

File tree

-11

lines changed

-11

lines changed

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3257,12 +3257,7 @@ transformJsonValueExpr(ParseState pstate, const char constructName,`
`3257`	`3257`	`parser_errposition(pstate,ve->format->location));`
`3258`	`3258`
`3259`	`3259`	`if (exprtype==JSONOID\|\|exprtype==JSONBOID)`
`3260`		`-{`
`3261`	`3260`	`format=JS_FORMAT_DEFAULT;/* do not format json[b] types */`
`3262`		`-ereport(WARNING,`
`3263`		`-errmsg("FORMAT JSON has no effect for json and jsonb types"),`
`3264`		`-parser_errposition(pstate,ve->format->location));`
`3265`		`-}`
`3266`	`3261`	`else`
`3267`	`3262`	`format=ve->format->format_type;`
`3268`	`3263`	`}`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -374,9 +374,6 @@ ERROR: JSON ENCODING clause is only allowed for bytea input type`
`374`	`374`	`LINE 1: SELECT JSON_OBJECT('foo': NULL::int FORMAT JSON ENCODING UTF...`
`375`	`375`	`^`
`376`	`376`	`SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);`
`377`		`-WARNING: FORMAT JSON has no effect for json and jsonb types`
`378`		`-LINE 1: SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);`
`379`		`- ^`
`380`	`377`	`json_object`
`381`	`378`	`----------------`
`382`	`379`	`{"foo" : null}`
`@@ -387,9 +384,6 @@ ERROR: JSON ENCODING clause is only allowed for bytea input type`
`387`	`384`	`LINE 1: SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON ENCODING UT...`
`388`	`385`	`^`
`389`	`386`	`SELECT JSON_OBJECT('foo': NULL::jsonb FORMAT JSON);`
`390`		`-WARNING: FORMAT JSON has no effect for json and jsonb types`
`391`		`-LINE 1: SELECT JSON_OBJECT('foo': NULL::jsonb FORMAT JSON);`
`392`		`- ^`
`393`	`387`	`json_object`
`394`	`388`	`---------------`
`395`	`389`	`{"foo": null}`

Comments

(0)