NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7c016e3

committed

Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv().

Due to oversights, the encrypt_iv() and decrypt_iv() functions failed toreport certain types of invalid-input errors, and would instead returnrandom garbage values.Marko Kreen, per report from Stefan Kaltenbrunner

1 parentb7922a6 commit7c016e3Copy full SHA for 7c016e3

File tree

1 file changed

-4

lines changed

contrib/pgcrypto
- pgcrypto.c

1 file changed

-4

lines changed

`‎contrib/pgcrypto/pgcrypto.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,8 +342,8 @@ pg_encrypt_iv(PG_FUNCTION_ARGS)`
`342`	`342`	`err=px_combo_init(c, (uint8*)VARDATA(key),klen,`
`343`	`343`	`(uint8*)VARDATA(iv),ivlen);`
`344`	`344`	`if (!err)`
`345`		`-px_combo_encrypt(c, (uint8*)VARDATA(data),dlen,`
`346`		`- (uint8*)VARDATA(res),&rlen);`
	`345`	`+err=px_combo_encrypt(c, (uint8*)VARDATA(data),dlen,`
	`346`	`+ (uint8*)VARDATA(res),&rlen);`
`347`	`347`
`348`	`348`	`px_combo_free(c);`
`349`	`349`
`@@ -396,8 +396,8 @@ pg_decrypt_iv(PG_FUNCTION_ARGS)`
`396`	`396`	`err=px_combo_init(c, (uint8*)VARDATA(key),klen,`
`397`	`397`	`(uint8*)VARDATA(iv),ivlen);`
`398`	`398`	`if (!err)`
`399`		`-px_combo_decrypt(c, (uint8*)VARDATA(data),dlen,`
`400`		`- (uint8*)VARDATA(res),&rlen);`
	`399`	`+err=px_combo_decrypt(c, (uint8*)VARDATA(data),dlen,`
	`400`	`+ (uint8*)VARDATA(res),&rlen);`
`401`	`401`
`402`	`402`	`px_combo_free(c);`
`403`	`403`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c016e3

File tree

1 file changed

1 file changed

`‎contrib/pgcrypto/pgcrypto.c`

0 commit comments