Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7bf40ea

Browse files
committed
Avoid using SplitIdentifierString to parse ListenAddresses, too.
This gets rid of our former behavior of forcibly downcasingthe postmaster's hostname list and truncating the elements toNAMEDATALEN. In principle, DNS hostnames are case-insensitiveso the first behavior should be harmless, and server hostnamesare seldom long enough for the second behavior to be an issue.But it's still dubious, and an easy fix is available: just useSplitGUCList instead.AFAICT, all other SplitIdentifierString calls in the backend areOK: either the items actually are SQL identifiers, or they arekeywords that are short and case-insensitive.Per thinking about bug #16106. While this has been wrong fora very long time, the lack of field complaints means there'slittle reason to back-patch.Discussion:https://postgr.es/m/16106-7d319e4295d08e70@postgresql.org
1 parent7618eaf commit7bf40ea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/backend/postmaster/postmaster.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,7 @@ PostmasterMain(int argc, char *argv[])
11341134
rawstring=pstrdup(ListenAddresses);
11351135

11361136
/* Parse string into list of hostnames */
1137-
if (!SplitIdentifierString(rawstring,',',&elemlist))
1137+
if (!SplitGUCList(rawstring,',',&elemlist))
11381138
{
11391139
/* syntax error in list */
11401140
ereport(FATAL,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp