NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7bee2e3

Michael Meskes

committed

ECPG: Make the preprocessor emit ';' if the variable type for a list of

variables is varchar. This fixes this test case:int main(void){ exec sql begin declare section; varchar a[50], b[50]; exec sql end declare section; return 0;}Since varchars are internally turned into custom structs andthe type name is emitted for these variable declarations,the preprocessed code previously had:struct varchar_1 { ... } a _,_ struct varchar_2 { ... } b ;The comma in the generated C file was a syntax error.There are no regression test changes since it's not exercised.Patch by Boszormenyi Zoltan <zb@cybertec.at>Conflicts:src/interfaces/ecpg/preproc/ecpg.trailer

1 parentcd5316f commit7bee2e3Copy full SHA for 7bee2e3

File tree

1 file changed

-1

lines changed

src/interfaces/ecpg/preproc
- ecpg.trailer

1 file changed

-1

lines changed

`‎src/interfaces/ecpg/preproc/ecpg.trailer‎`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,12 @@ opt_signed: SQL_SIGNED`
`831`	`831`	`variable_list: variable`
`832`	`832`	`{ $$ = $1; }`
`833`	`833`	`\| variable_list ',' variable`
`834`		`-{ $$ = cat_str(3, $1, make_str(","), $3); }`
	`834`	`+{`
	`835`	`+if (actual_type[struct_level].type_enum == ECPGt_varchar)`
	`836`	`+$$ = cat_str(3, $1, make_str(";"), $3);`
	`837`	`+else`
	`838`	`+$$ = cat_str(3, $1, make_str(","), $3);`
	`839`	`+}`
`835`	`840`	`;`
`836`	`841`
`837`	`842`	`variable: opt_pointer ECPGColLabel opt_array_bounds opt_bit_field opt_initializer`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7bee2e3

File tree

1 file changed

1 file changed

`‎src/interfaces/ecpg/preproc/ecpg.trailer‎`

0 commit comments