Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7bae028

Browse files
committed
Avoid transaction-commit race condition while receiving a NOTIFY message.
Use TransactionIdIsInProgress, then TransactionIdDidCommit, to distinguishwhether a NOTIFY message's originating transaction is in progress,committed, or aborted. The previous coding could accept a message from atransaction that was still in-progress according to the PGPROC array;if the client were fast enough at starting a new transaction, it might failto see table rows added/updated by the message-sending transaction. Whichof course would usually be the point of receiving the message. We notedthis type of race condition long ago in tqual.c, but async.c overlooked it.The race condition probably cannot occur unless there are multiple NOTIFYsenders in action, since an individual backend doesn't send NOTIFY signalsuntil well after it's done committing. But if two senders commit in closesuccession, it's certainly possible that we could see the second sender'smessage within the race condition window while responding to the signalfrom the first one.Per bug #9557 from Marko Tiikkaja. This patch is slightly more invasivethan what he proposed, since it removes the now-redundantTransactionIdDidAbort call.Back-patch to 9.0, where the current NOTIFY implementation was introduced.
1 parent16ff08b commit7bae028

File tree

1 file changed

+24
-18
lines changed

1 file changed

+24
-18
lines changed

‎src/backend/commands/async.c

Lines changed: 24 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@
126126
#include"miscadmin.h"
127127
#include"storage/ipc.h"
128128
#include"storage/lmgr.h"
129+
#include"storage/procarray.h"
129130
#include"storage/procsignal.h"
130131
#include"storage/sinval.h"
131132
#include"tcop/tcopprot.h"
@@ -1978,7 +1979,27 @@ asyncQueueProcessPageEntries(QueuePosition *current,
19781979
/* Ignore messages destined for other databases */
19791980
if (qe->dboid==MyDatabaseId)
19801981
{
1981-
if (TransactionIdDidCommit(qe->xid))
1982+
if (TransactionIdIsInProgress(qe->xid))
1983+
{
1984+
/*
1985+
* The source transaction is still in progress, so we can't
1986+
* process this message yet. Break out of the loop, but first
1987+
* back up *current so we will reprocess the message next
1988+
* time. (Note: it is unlikely but not impossible for
1989+
* TransactionIdDidCommit to fail, so we can't really avoid
1990+
* this advance-then-back-up behavior when dealing with an
1991+
* uncommitted message.)
1992+
*
1993+
* Note that we must test TransactionIdIsInProgress before we
1994+
* test TransactionIdDidCommit, else we might return a message
1995+
* from a transaction that is not yet visible to snapshots;
1996+
* compare the comments at the head of tqual.c.
1997+
*/
1998+
*current=thisentry;
1999+
reachedStop= true;
2000+
break;
2001+
}
2002+
elseif (TransactionIdDidCommit(qe->xid))
19822003
{
19832004
/* qe->data is the null-terminated channel name */
19842005
char*channel=qe->data;
@@ -1991,27 +2012,12 @@ asyncQueueProcessPageEntries(QueuePosition *current,
19912012
NotifyMyFrontEnd(channel,payload,qe->srcPid);
19922013
}
19932014
}
1994-
elseif (TransactionIdDidAbort(qe->xid))
1995-
{
1996-
/*
1997-
* If the source transaction aborted, we just ignore its
1998-
* notifications.
1999-
*/
2000-
}
20012015
else
20022016
{
20032017
/*
2004-
* The transaction has neither committed nor aborted so far,
2005-
* so we can't process its message yet. Break out of the
2006-
* loop, but first back up *current so we will reprocess the
2007-
* message next time. (Note: it is unlikely but not
2008-
* impossible for TransactionIdDidCommit to fail, so we can't
2009-
* really avoid this advance-then-back-up behavior when
2010-
* dealing with an uncommitted message.)
2018+
* The source transaction aborted or crashed, so we just
2019+
* ignore its notifications.
20112020
*/
2012-
*current=thisentry;
2013-
reachedStop= true;
2014-
break;
20152021
}
20162022
}
20172023

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp