NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7b64e4b

committed

pgstat: drop subscription stats without slot as well, fix comment

There's no reason anymore to only drop subscription stats if associated with aslot, now that stats drops are transactional. And since there's now no othercleanup of stats, this would lead to stats for slot-less subscriptions to getleaked (however most slot-less subs won't have stats).Additionally, the comment referring to autovacuum cleaning up stats wasclearly outdated.Author: Masahiko Sawada <sawada.mshk@gmail.com>Discussion:https://postgr.es/m/CAD21AoAwiby3HeJE7vJe16Gr75RFfJ640dyHqvsiUhyKJTXPtw@mail.gmail.comBackpatch: 15-

1 parentb0a55e4 commit7b64e4bCopy full SHA for 7b64e4b

File tree

1 file changed

-8

lines changed

src/backend/commands
- subscriptioncmds.c

1 file changed

-8

lines changed

`‎src/backend/commands/subscriptioncmds.c`

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1578,15 +1578,9 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel)`
`1578`	`1578`
`1579`	`1579`	`/*`
`1580`	`1580`	`* Tell the cumulative stats system that the subscription is getting`
`1581`		`- * dropped. We can safely report dropping the subscription statistics here`
`1582`		`- * if the subscription is associated with a replication slot since we`
`1583`		`- * cannot run DROP SUBSCRIPTION inside a transaction block. Subscription`
`1584`		`- * statistics will be removed later by (auto)vacuum either if it's not`
`1585`		`- * associated with a replication slot or if the message for dropping the`
`1586`		`- * subscription gets lost.`
	`1581`	`+ * dropped.`
`1587`	`1582`	`*/`
`1588`		`-if (slotname)`
`1589`		`-pgstat_drop_subscription(subid);`
	`1583`	`+pgstat_drop_subscription(subid);`
`1590`	`1584`
`1591`	`1585`	`table_close(rel,NoLock);`
`1592`	`1586`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7b64e4b

File tree

1 file changed

1 file changed

`‎src/backend/commands/subscriptioncmds.c`

0 commit comments