NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7b6468c

committed

Rework macro pgstat_is_ioop_tracked_in_bytes()

As written, it was triggering a compilation warning for old versions ofclang, as reported by buildfarm members ayu, batfish and demoiselle.Forcing a cast with "unsigned int" should fix the warning.While on it, the macro is moved to pgstat.h, closer to the declarationof IOOp, per suggestion from Tom Lane.Reported-by: Tom LaneReviewed-by: Bertrand Drouvot, Tom Lane, Nazir Bilal YavuzDiscussion:https://postgr.es/m/1272824.1736961543@sss.pgh.pa.us

1 parentd4a43b2 commit7b6468cCopy full SHA for 7b6468c

File tree

2 files changed

-8

lines changed

src
- backend/utils/activity
  - pgstat_io.c
- include
  - pgstat.h

2 files changed

-8

lines changed

`‎src/backend/utils/activity/pgstat_io.c‎`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,14 +23,6 @@`
`23`	`23`	`staticPgStat_PendingIOPendingIOStats;`
`24`	`24`	`staticboolhave_iostats= false;`
`25`	`25`
`26`		`-/*`
`27`		`- * Check if an IOOp is tracked in bytes. This relies on the ordering of IOOp`
`28`		`- * defined in pgstat.h, so make sure to update this check when changing its`
`29`		`- * elements.`
`30`		`- */`
`31`		`-#definepgstat_is_ioop_tracked_in_bytes(io_op) \`
`32`		`-((io_op) < IOOP_NUM_TYPES && (io_op) >= IOOP_EXTEND)`
`33`		`-`
`34`	`26`	`/*`
`35`	`27`	`* Check that stats have not been counted for any combination of IOObject,`
`36`	`28`	`* IOContext, and IOOp which are not tracked for the passed-in BackendType. If`

`‎src/include/pgstat.h‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,10 @@ typedef enum IOOp`
`314`	`314`
`315`	`315`	`#defineIOOP_NUM_TYPES (IOOP_WRITE + 1)`
`316`	`316`
	`317`	`+#definepgstat_is_ioop_tracked_in_bytes(io_op) \`
	`318`	`+(((unsigned int) (io_op)) < IOOP_NUM_TYPES && \`
	`319`	`+ ((unsigned int) (io_op)) >= IOOP_EXTEND)`
	`320`	`+`
`317`	`321`	`typedefstructPgStat_BktypeIO`
`318`	`322`	`{`
`319`	`323`	`uint64bytes[IOOBJECT_NUM_TYPES][IOCONTEXT_NUM_TYPES][IOOP_NUM_TYPES];`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7b6468c

File tree

2 files changed

2 files changed

`‎src/backend/utils/activity/pgstat_io.c‎`

`‎src/include/pgstat.h‎`

0 commit comments