Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit7b46ef1

Browse files
committed
Fix minor bugs in commit30bf468 et al.
Coverity complained that the "else" added to fillPGconn() was unreachable,which it was. Remove the dead code. In passing, rearrange the tests so asnot to bother trying to fetch values for options that can't be assigned.Pre-9.3 did not have that issue, but it did have a "return" that should be"goto oom_error" to ensure that a suitable error message gets filled in.
1 parenta1cd04c commit7b46ef1

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

‎src/interfaces/libpq/fe-connect.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ fillPGconn(PGconn *conn, PQconninfoOption *connOptions)
664664
free(conn->sslmode);
665665
conn->sslmode=strdup("require");
666666
if (!conn->sslmode)
667-
return false;
667+
gotooom_error;
668668
}
669669
#endif
670670
FILL_CONN_OPTION(conn->requirepeer,"requirepeer");
@@ -767,7 +767,6 @@ connectOptions2(PGconn *conn)
767767
conn->pgpass=strdup(DefaultPassword);
768768
if (!conn->pgpass)
769769
gotooom_error;
770-
771770
}
772771
else
773772
conn->dot_pgpass_used= true;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp