NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7b158d1

committed

Suppress extensions in partial dumps.

We initially had pg_dump emit CREATE EXTENSION commands unconditionally.However, pg_dump has long been in the habit of not dumping procedurallanguage definitions when a --schema or --table switch is given. It seemsappropriate to handle extensions the same way, since like PLs they are SQLobjects that are not in any particular schema. Per complaint from AdrianSchreyer.

1 parent3439e40 commit7b158d1Copy full SHA for 7b158d1

File tree

1 file changed

-5

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-5

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1153,18 +1153,19 @@ selectDumpableDefaultACL(DefaultACLInfo *dinfo)`
`1153`	`1153`	`* selectDumpableExtension: policy-setting subroutine`
`1154`	`1154`	`*Mark an extension as to be dumped or not`
`1155`	`1155`	`*`
`1156`		`- * Normally, we just dump all extensions. However, in binary-upgrade mode`
`1157`		`- * it's necessary to skip built-in extensions, since we assume those will`
`1158`		`- * already be installed in the target database. We identify such extensions`
`1159`		`- * by their having OIDs in the range reserved for initdb.`
	`1156`	`+ * Normally, we dump all extensions, or none of them if include_everything`
	`1157`	`+ * is false (i.e., a --schema or --table switch was given). However, in`
	`1158`	`+ * binary-upgrade mode it's necessary to skip built-in extensions, since we`
	`1159`	`+ * assume those will already be installed in the target database. We identify`
	`1160`	`+ * such extensions by their having OIDs in the range reserved for initdb.`
`1160`	`1161`	`*/`
`1161`	`1162`	`staticvoid`
`1162`	`1163`	`selectDumpableExtension(ExtensionInfo*extinfo)`
`1163`	`1164`	`{`
`1164`	`1165`	`if (binary_upgrade&&extinfo->dobj.catId.oid< (Oid)FirstNormalObjectId)`
`1165`	`1166`	`extinfo->dobj.dump= false;`
`1166`	`1167`	`else`
`1167`		`-extinfo->dobj.dump=true;`
	`1168`	`+extinfo->dobj.dump=include_everything;`
`1168`	`1169`	`}`
`1169`	`1170`
`1170`	`1171`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7b158d1

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments