NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7b14bcc

committed

Fix lock level used for partition when detaching it

For probably bogus reasons, we acquire only AccessShareLock on thepartition when we try to detach it from its parent partitioned table.This can cause ugly things to happen if another transaction is doingany sort of DDL to the partition concurrently.Upgrade that lock to ShareUpdateExclusiveLock, which per discussionseems to be the minimum needed.Reported by Robert Haas.Discussion:https://postgr.es/m/CA+TgmoYruJQ+2qnFLtF1xQtr71pdwgfxy3Ziy-TxV28M6pEmyA@mail.gmail.com

1 parent42bdf85 commit7b14bccCopy full SHA for 7b14bcc

File tree

1 file changed

-1

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -14588,7 +14588,7 @@ ATExecDetachPartition(Relation rel, RangeVar *name)`
`14588`	`14588`	`if (OidIsValid(defaultPartOid))`
`14589`	`14589`	`LockRelationOid(defaultPartOid,AccessExclusiveLock);`
`14590`	`14590`
`14591`		`-partRel=heap_openrv(name,AccessShareLock);`
	`14591`	`+partRel=heap_openrv(name,ShareUpdateExclusiveLock);`
`14592`	`14592`
`14593`	`14593`	`/* All inheritance related checks are performed within the function */`
`14594`	`14594`	`RemoveInheritance(partRel,rel);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7b14bcc

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments