NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7ac0f8d

committed

Fix broken hash function hashbpcharextended().

Ignore trailing spaces for non-deterministic collations whenhashing.The previous behavior could lead to tuples falling into the wrongpartitions when hash partitioning is combined with the BPCHAR type anda non-deterministic collation. Fortunately, it did not affect hashindexes, because hash indexes do not use extended hash functions.Decline to backpatch, per discussion.Discussion:https://postgr.es/m/eb83d0ac7b299eb08f9b900dd08a5a0c5d90e517.camel@j-davis.comReviewed-by: Richard Guo, Tom Lane

1 parent4c689a6 commit7ac0f8dCopy full SHA for 7ac0f8d

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- varchar.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/varchar.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1086,7 +1086,7 @@ hashbpcharextended(PG_FUNCTION_ARGS)`
`1086`	`1086`	`Sizebsize;`
`1087`	`1087`	`uint8_t*buf;`
`1088`	`1088`
`1089`		`-ulen=icu_to_uchar(&uchar,VARDATA_ANY(key),VARSIZE_ANY_EXHDR(key));`
	`1089`	`+ulen=icu_to_uchar(&uchar,keydata,keylen);`
`1090`	`1090`
`1091`	`1091`	`bsize=ucol_getSortKey(mylocale->info.icu.ucol,`
`1092`	`1092`	`uchar,ulen,NULL,0);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7ac0f8d

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/varchar.c`

0 commit comments