forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit7a85073

Amit Kapila
Reconsider pg_stat_subscription_workers view.
It was decided (refer to the Discussion link below) that the statscollector is not an appropriate place to store the error information ofsubscription workers.This patch changes the pg_stat_subscription_workers view (introduced bycommit8d74fc9) so that it stores only statistics counters:apply_error_count and sync_error_count, and has one entry foreach subscription. The removed error information such as error-XID andthe error message would be stored in another way in the future which ismore reliable and persistent.After removing these error details, there is no longer any relationinformation, so the subscription statistics are now a cluster-widestatistics.The patch also changes the view name to pg_stat_subscription_stats sincethe word "worker" is an implementation detail that we use one worker forone tablesync and one apply.Author: Masahiko Sawada, based on suggestions by Andres FreundReviewed-by: Peter Smith, Haiying Tang, Takamichi Osumi, Amit KapilaDiscussion:https://postgr.es/m/20220125063131.4cmvsxbz2tdg6g65@alap3.anarazel.de1 parent54bd1e4 commit7a85073
File tree
14 files changed
+582
-864
lines changed- doc/src/sgml
- src
- backend
- catalog
- postmaster
- replication/logical
- utils/adt
- include
- catalog
- test
- regress/expected
- subscription/t
- tools/pgindent
14 files changed
+582
-864
lines changedLines changed: 1 addition & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
346 | 346 |
| |
347 | 347 |
| |
348 | 348 |
| |
349 |
| - | |
350 |
| - | |
351 |
| - | |
| 349 | + | |
352 | 350 |
| |
353 | 351 |
| |
354 | 352 |
| |
|
Lines changed: 24 additions & 75 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
628 | 628 |
| |
629 | 629 |
| |
630 | 630 |
| |
631 |
| - | |
632 |
| - | |
633 |
| - | |
634 |
| - | |
635 |
| - | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
636 | 635 |
| |
637 | 636 |
| |
638 | 637 |
| |
| |||
3063 | 3062 |
| |
3064 | 3063 |
| |
3065 | 3064 |
| |
3066 |
| - | |
3067 |
| - | |
| 3065 | + | |
| 3066 | + | |
3068 | 3067 |
| |
3069 | 3068 |
| |
3070 |
| - | |
| 3069 | + | |
3071 | 3070 |
| |
3072 | 3071 |
| |
3073 | 3072 |
| |
3074 |
| - | |
3075 |
| - | |
3076 |
| - | |
3077 |
| - | |
3078 |
| - | |
| 3073 | + | |
| 3074 | + | |
3079 | 3075 |
| |
3080 | 3076 |
| |
3081 |
| - | |
3082 |
| - | |
| 3077 | + | |
| 3078 | + | |
3083 | 3079 |
| |
3084 | 3080 |
| |
3085 | 3081 |
| |
| |||
3113 | 3109 |
| |
3114 | 3110 |
| |
3115 | 3111 |
| |
3116 |
| - | |
| 3112 | + | |
3117 | 3113 |
| |
3118 | 3114 |
| |
3119 |
| - | |
3120 |
| - | |
3121 |
| - | |
3122 |
| - | |
3123 |
| - | |
3124 |
| - | |
3125 |
| - | |
3126 |
| - | |
3127 |
| - | |
3128 |
| - | |
3129 |
| - | |
3130 |
| - | |
| 3115 | + | |
3131 | 3116 |
| |
3132 | 3117 |
| |
3133 | 3118 |
| |
3134 | 3119 |
| |
3135 | 3120 |
| |
3136 |
| - | |
| 3121 | + | |
3137 | 3122 |
| |
3138 | 3123 |
| |
3139 |
| - | |
3140 |
| - | |
| 3124 | + | |
| 3125 | + | |
3141 | 3126 |
| |
3142 | 3127 |
| |
3143 | 3128 |
| |
3144 | 3129 |
| |
3145 | 3130 |
| |
3146 |
| - | |
3147 |
| - | |
3148 |
| - | |
3149 |
| - | |
3150 |
| - | |
3151 |
| - | |
3152 |
| - | |
3153 |
| - | |
3154 |
| - | |
3155 |
| - | |
3156 |
| - | |
3157 |
| - | |
3158 |
| - | |
3159 |
| - | |
3160 |
| - | |
3161 |
| - | |
3162 |
| - | |
3163 |
| - | |
3164 |
| - | |
3165 |
| - | |
3166 |
| - | |
3167 |
| - | |
3168 |
| - | |
3169 |
| - | |
3170 |
| - | |
3171 |
| - | |
3172 |
| - | |
3173 |
| - | |
3174 |
| - | |
3175 |
| - | |
| 3131 | + | |
3176 | 3132 |
| |
3177 | 3133 |
| |
3178 |
| - | |
| 3134 | + | |
3179 | 3135 |
| |
3180 | 3136 |
| |
3181 |
| - | |
3182 | 3137 |
| |
3183 | 3138 |
| |
3184 | 3139 |
| |
| |||
5320 | 5275 |
| |
5321 | 5276 |
| |
5322 | 5277 |
| |
5323 |
| - | |
| 5278 | + | |
5324 | 5279 |
| |
5325 |
| - | |
| 5280 | + | |
5326 | 5281 |
| |
5327 | 5282 |
| |
5328 | 5283 |
| |
5329 |
| - | |
5330 |
| - | |
5331 |
| - | |
5332 |
| - | |
5333 |
| - | |
5334 |
| - | |
5335 |
| - | |
5336 |
| - | |
5337 |
| - | |
5338 |
| - | |
| 5284 | + | |
| 5285 | + | |
| 5286 | + | |
| 5287 | + | |
5339 | 5288 |
| |
5340 | 5289 |
| |
5341 | 5290 |
| |
|
Lines changed: 1 addition & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
639 | 639 |
| |
640 | 640 |
| |
641 | 641 |
| |
642 |
| - | |
643 |
| - | |
644 |
| - | |
| 642 | + | |
645 | 643 |
| |
646 | 644 |
| |
647 | 645 |
| |
|
Lines changed: 7 additions & 20 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1264 | 1264 |
| |
1265 | 1265 |
| |
1266 | 1266 |
| |
1267 |
| - | |
| 1267 | + | |
1268 | 1268 |
| |
1269 |
| - | |
| 1269 | + | |
1270 | 1270 |
| |
1271 |
| - | |
1272 |
| - | |
1273 |
| - | |
1274 |
| - | |
1275 |
| - | |
1276 |
| - | |
1277 |
| - | |
1278 |
| - | |
1279 |
| - | |
1280 |
| - | |
1281 |
| - | |
1282 |
| - | |
1283 |
| - | |
1284 |
| - | |
1285 |
| - | |
1286 |
| - | |
1287 |
| - | |
1288 |
| - | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + |
0 commit comments
Comments
(0)