Commit7a424ec

Amit Kapila

committed

Add more LOG and DEBUG messages for slot synchronization.

This provides more information about remote slots during synchronizationwhich helps in debugging bugs and BF failures due to test case issues. Wemight later want to change the LOG message added by this patch to DEBUG1.Author: Hou ZhijieReviewed-by: Amit Kapila, Bertrand DrouvotDiscussion:https://postgr.es/m/514f6f2f-6833-4539-39f1-96cd1e011f23@enterprisedb.comDiscussion:https://postgr.es/m/OS0PR01MB571633C23B2A4CAC5FB0371A944C2@OS0PR01MB5716.jpnprd01.prod.outlook.com

1 parent1fe6668 commit7a424ecCopy full SHA for 7a424ec

File tree

+14

-0

lines changed

+14

-0

lines changed

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -321,6 +321,9 @@ reserve_wal_for_local_slot(XLogRecPtr restart_lsn)`
`321`	`321`	`oldest_segno=XLogGetOldestSegno(cur_timeline);`
`322`	`322`	`}`
`323`	`323`
	`324`	`+elog(DEBUG1,"segno: %ld of purposed restart_lsn for the synced slot, oldest_segno: %ld available",`
	`325`	`+segno,oldest_segno);`
	`326`	`+`
`324`	`327`	`/*`
`325`	`328`	`* If all required WAL is still there, great, otherwise retry. The`
`326`	`329`	`* slot should prevent further removal of WAL, unless there's a`
`@@ -361,7 +364,18 @@ update_and_persist_local_synced_slot(RemoteSlot *remote_slot, Oid remote_dbid)`
`361`	`364`	`* current location when recreating the slot in the next cycle. It may`
`362`	`365`	`* take more time to create such a slot. Therefore, we keep this slot`
`363`	`366`	`* and attempt the synchronization in the next cycle.`
	`367`	`+ *`
	`368`	`+ * XXX should this be changed to elog(DEBUG1) perhaps?`
`364`	`369`	`*/`
	`370`	`+ereport(LOG,`
	`371`	`+errmsg("could not sync slot information as remote slot precedes local slot:"`
	`372`	`+" remote slot \"%s\": LSN (%X/%X), catalog xmin (%u) local slot: LSN (%X/%X), catalog xmin (%u)",`
	`373`	`+remote_slot->name,`
	`374`	`+LSN_FORMAT_ARGS(remote_slot->restart_lsn),`
	`375`	`+remote_slot->catalog_xmin,`
	`376`	`+LSN_FORMAT_ARGS(slot->data.restart_lsn),`
	`377`	`+slot->data.catalog_xmin));`
	`378`	`+`
`365`	`379`	`return;`
`366`	`380`	`}`
`367`	`381`

Comments

(0)