NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7a28e9a

committed

Fix test_rls_hooks to assign expression collations properly.

This module overlooked this necessary fixup step on the results oftransformWhereClause(). It accidentally worked anyway, because theconstructed expression involved type "name" which is not collatable,but it fell over while I was experimenting with changing "name" tobe collatable.Back-patch, not because there's any live bug here in back branches,but because somebody might use this code as a model for some realapplication and then not understand why it doesn't work.

1 parentd65ddb2 commit7a28e9aCopy full SHA for 7a28e9a

File tree

1 file changed

-0

lines changed

src/test/modules/test_rls_hooks
- test_rls_hooks.c

1 file changed

-0

lines changed

`‎src/test/modules/test_rls_hooks/test_rls_hooks.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`#include"nodes/makefuncs.h"`
`23`	`23`	`#include"nodes/makefuncs.h"`
`24`	`24`	`#include"parser/parse_clause.h"`
	`25`	`+#include"parser/parse_collate.h"`
`25`	`26`	`#include"parser/parse_node.h"`
`26`	`27`	`#include"parser/parse_relation.h"`
`27`	`28`	`#include"rewrite/rowsecurity.h"`
`@@ -107,6 +108,8 @@ test_rls_hooks_permissive(CmdType cmdtype, Relation relation)`
`107`	`108`	`policy->qual= (Expr*)transformWhereClause(qual_pstate,copyObject(e),`
`108`	`109`	`EXPR_KIND_POLICY,`
`109`	`110`	`"POLICY");`
	`111`	`+/* Fix up collation information */`
	`112`	`+assign_expr_collations(qual_pstate, (Node*)policy->qual);`
`110`	`113`
`111`	`114`	`policy->with_check_qual=copyObject(policy->qual);`
`112`	`115`	`policy->hassublinks= false;`
`@@ -165,6 +168,8 @@ test_rls_hooks_restrictive(CmdType cmdtype, Relation relation)`
`165`	`168`	`policy->qual= (Expr*)transformWhereClause(qual_pstate,copyObject(e),`
`166`	`169`	`EXPR_KIND_POLICY,`
`167`	`170`	`"POLICY");`
	`171`	`+/* Fix up collation information */`
	`172`	`+assign_expr_collations(qual_pstate, (Node*)policy->qual);`
`168`	`173`
`169`	`174`	`policy->with_check_qual=copyObject(policy->qual);`
`170`	`175`	`policy->hassublinks= false;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7a28e9a

File tree

1 file changed

1 file changed

`‎src/test/modules/test_rls_hooks/test_rls_hooks.c`

0 commit comments