Commit79b575d

committed

Fix ALTER TABLE / REPLICA IDENTITY for temporal tables

REPLICA IDENTITY USING INDEX did not accept a GiST index. This shouldbe allowed when used as a temporal primary key.Author: Paul Jungwirth <pj@illuminatedcomputing.com>Discussion:https://www.postgresql.org/message-id/04579cbf-b134-45e1-8f2d-8c54c849c1ee@illuminatedcomputing.com

1 parentda94e87 commit79b575dCopy full SHA for 79b575d

File tree

+28

-6

lines changed

+28

-6

lines changed

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -17296,9 +17296,14 @@ ATExecReplicaIdentity(Relation rel, ReplicaIdentityStmt *stmt, LOCKMODE lockmode`
`17296`	`17296`	`errmsg("\"%s\" is not an index for table \"%s\"",`
`17297`	`17297`	`RelationGetRelationName(indexRel),`
`17298`	`17298`	`RelationGetRelationName(rel))));`
`17299`		`-/* The AM must support uniqueness, and the index must in fact be unique. */`
`17300`		`-if (!indexRel->rd_indam->amcanunique \|\|`
`17301`		`-!indexRel->rd_index->indisunique)`
	`17299`	`+/*`
	`17300`	`+ * The AM must support uniqueness, and the index must in fact be unique.`
	`17301`	`+ * If we have a WITHOUT OVERLAPS constraint (identified by uniqueness +`
	`17302`	`+ * exclusion), we can use that too.`
	`17303`	`+ */`
	`17304`	`+if ((!indexRel->rd_indam->amcanunique \|\|`
	`17305`	`+ !indexRel->rd_index->indisunique) &&`
	`17306`	`+!(indexRel->rd_index->indisunique && indexRel->rd_index->indisexclusion))`
`17302`	`17307`	`ereport(ERROR,`
`17303`	`17308`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`17304`	`17309`	`errmsg("cannot use non-unique index \"%s\" as replica identity",`

Lines changed: 18 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -978,9 +978,25 @@ SELECT * FROM tp2 ORDER BY id, valid_at;`
`978`	`978`
`979`	`979`	`DROP TABLE temporal_partitioned;`
`980`	`980`	`-- ALTER TABLE REPLICA IDENTITY`
`981`		`--- (should fail)`
	`981`	`+\d temporal_rng`
	`982`	`+ Table "public.temporal_rng"`
	`983`	`+ Column \| Type \| Collation \| Nullable \| Default`
	`984`	`+----------+-----------+-----------+----------+---------`
	`985`	`+ id \| int4range \| \| not null \|`
	`986`	`+ valid_at \| daterange \| \| not null \|`
	`987`	`+Indexes:`
	`988`	`+ "temporal_rng_pk" PRIMARY KEY (id, valid_at WITHOUT OVERLAPS)`
	`989`	`+`
`982`	`990`	`ALTER TABLE temporal_rng REPLICA IDENTITY USING INDEX temporal_rng_pk;`
`983`		`-ERROR: cannot use non-unique index "temporal_rng_pk" as replica identity`
	`991`	`+\d temporal_rng`
	`992`	`+ Table "public.temporal_rng"`
	`993`	`+ Column \| Type \| Collation \| Nullable \| Default`
	`994`	`+----------+-----------+-----------+----------+---------`
	`995`	`+ id \| int4range \| \| not null \|`
	`996`	`+ valid_at \| daterange \| \| not null \|`
	`997`	`+Indexes:`
	`998`	`+ "temporal_rng_pk" PRIMARY KEY (id, valid_at WITHOUT OVERLAPS) REPLICA IDENTITY`
	`999`	`+`
`984`	`1000`	`--`
`985`	`1001`	`-- ON CONFLICT: ranges`
`986`	`1002`	`--`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -691,8 +691,9 @@ SELECT * FROM tp2 ORDER BY id, valid_at;`
`691`	`691`	`DROPTABLE temporal_partitioned;`
`692`	`692`
`693`	`693`	`-- ALTER TABLE REPLICA IDENTITY`
`694`		`--- (should fail)`
	`694`	`+\d temporal_rng`
`695`	`695`	`ALTERTABLE temporal_rng REPLICA IDENTITY USING INDEX temporal_rng_pk;`
	`696`	`+\d temporal_rng`
`696`	`697`
`697`	`698`	`--`
`698`	`699`	`-- ON CONFLICT: ranges`

Comments

(0)