forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit7968184
committed
Remove pgbench's restriction on placement of -M switch.
Previously the -M switch had to appear before any switch that directlyor indirectly specified a benchmarking script. This was both confusingand inadequately documented, as per gripe from Tatsuo Ishii. We canremove the restriction at the cost of making an extra pass over thelists of SQL commands, which seems like a cheap price (the string scansthemselves likely cost much more). The change is just to not extractparameters from the SQL commands until we have finished parsing theswitches and know the final value of -M.Per discussion, we'll treat this as a low-grade bug fix and sneak itinto v10, rather than holding it for v11.Tom Lane, reviewed by Tatsuo Ishii and Fabien CoelhoDiscussion:https://postgr.es/m/20170802.110328.1963639094551443169.t-ishii@sraoss.co.jpDiscussion:https://postgr.es/m/10208.1502465077@sss.pgh.pa.us1 parenta1ef920 commit7968184
1 file changed
+34
-25
lines changedLines changed: 34 additions & 25 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2844 | 2844 |
| |
2845 | 2845 |
| |
2846 | 2846 |
| |
2847 |
| - | |
| 2847 | + | |
| 2848 | + | |
2848 | 2849 |
| |
2849 | 2850 |
| |
2850 |
| - | |
| 2851 | + | |
2851 | 2852 |
| |
2852 | 2853 |
| |
2853 | 2854 |
| |
2854 | 2855 |
| |
2855 |
| - | |
| 2856 | + | |
| 2857 | + | |
| 2858 | + | |
2856 | 2859 |
| |
2857 | 2860 |
| |
2858 | 2861 |
| |
| |||
2874 | 2877 |
| |
2875 | 2878 |
| |
2876 | 2879 |
| |
2877 |
| - | |
| 2880 | + | |
| 2881 | + | |
2878 | 2882 |
| |
2879 | 2883 |
| |
2880 | 2884 |
| |
| |||
2886 | 2890 |
| |
2887 | 2891 |
| |
2888 | 2892 |
| |
| 2893 | + | |
2889 | 2894 |
| |
2890 | 2895 |
| |
2891 | 2896 |
| |
| |||
2983 | 2988 |
| |
2984 | 2989 |
| |
2985 | 2990 |
| |
2986 |
| - | |
2987 | 2991 |
| |
2988 | 2992 |
| |
| 2993 | + | |
| 2994 | + | |
| 2995 | + | |
| 2996 | + | |
| 2997 | + | |
| 2998 | + | |
| 2999 | + | |
2989 | 3000 |
| |
2990 | 3001 |
| |
2991 | 3002 |
| |
| |||
3000 | 3011 |
| |
3001 | 3012 |
| |
3002 | 3013 |
| |
3003 |
| - | |
3004 |
| - | |
3005 |
| - | |
3006 |
| - | |
3007 |
| - | |
3008 |
| - | |
3009 |
| - | |
3010 |
| - | |
3011 |
| - | |
3012 |
| - | |
3013 |
| - | |
3014 |
| - | |
3015 |
| - | |
3016 |
| - | |
3017 |
| - | |
3018 | 3014 |
| |
3019 | 3015 |
| |
3020 | 3016 |
| |
| |||
3896 | 3892 |
| |
3897 | 3893 |
| |
3898 | 3894 |
| |
3899 |
| - | |
3900 |
| - | |
3901 |
| - | |
3902 |
| - | |
3903 |
| - | |
3904 | 3895 |
| |
3905 | 3896 |
| |
3906 | 3897 |
| |
| |||
4006 | 3997 |
| |
4007 | 3998 |
| |
4008 | 3999 |
| |
| 4000 | + | |
| 4001 | + | |
| 4002 | + | |
| 4003 | + | |
| 4004 | + | |
| 4005 | + | |
| 4006 | + | |
| 4007 | + | |
| 4008 | + | |
| 4009 | + | |
| 4010 | + | |
| 4011 | + | |
| 4012 | + | |
| 4013 | + | |
| 4014 | + | |
| 4015 | + | |
| 4016 | + | |
| 4017 | + | |
4009 | 4018 |
| |
4010 | 4019 |
| |
4011 | 4020 |
| |
|
0 commit comments
Comments
(0)