NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit790eaa6

committed

Check dup2() results in syslogger

Consistently check the dup2() call results throughout syslogger.c.It's pretty unlikely that they'll error out, but if they do,ereport(FATAL) instead of blissfully continuing on.Spotted by the Coverity scanner.

1 parentf2795f8 commit790eaa6Copy full SHA for 790eaa6

File tree

1 file changed

-2

lines changed

src/backend/postmaster
- syslogger.c

1 file changed

-2

lines changed

`‎src/backend/postmaster/syslogger.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -210,8 +210,14 @@ SysLoggerMain(int argc, char *argv[])`
`210`	`210`	`close(fileno(stderr));`
`211`	`211`	`if (fd!=-1)`
`212`	`212`	`{`
`213`		`-dup2(fd,fileno(stdout));`
`214`		`-dup2(fd,fileno(stderr));`
	`213`	`+if (dup2(fd,fileno(stdout))<0)`
	`214`	`+ereport(FATAL,`
	`215`	`+(errcode_for_file_access(),`
	`216`	`+errmsg("could not redirect stdout: %m")));`
	`217`	`+if (dup2(fd,fileno(stderr))<0)`
	`218`	`+ereport(FATAL,`
	`219`	`+(errcode_for_file_access(),`
	`220`	`+errmsg("could not redirect stderr: %m")));`
`215`	`221`	`close(fd);`
`216`	`222`	`}`
`217`	`223`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit790eaa6

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/syslogger.c`

0 commit comments