NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit78f91f1

committed

Fix bug in the test of file descriptor of current WAL file in pg_receivexlog.

In pg_receivexlog, in order to check whether the current WAL file isbeing opened or not, its file descriptor has to be checked against -1as an invalid value. But, oops,7900e94 added the incorrect testchecking the descriptor against 1. This commit fixes that bug.Back-patch to 9.4 where the bug was added.Spotted by Magnus Hagander

1 parent7900e94 commit78f91f1Copy full SHA for 78f91f1

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -919,7 +919,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`919`	`919`	`if (replyRequested&&still_sending)`
`920`	`920`	`{`
`921`	`921`	`if (reportFlushPosition&&lastFlushPosition<blockpos&&`
`922`		`-walfile!=1)`
	`922`	`+walfile!=-1)`
`923`	`923`	`{`
`924`	`924`	`/*`
`925`	`925`	`* If a valid flush location needs to be reported,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit78f91f1

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c`

0 commit comments