NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit78f7ba1

committed

Tatsuo Ishii <t-ishii@sra.co.jp> writes:

> As you can see, psql reconnect as any user if the password is same as> foo. Of course this is due to the careless password setting, but I> think it's better to prompt ANY TIME the user tries to switch to> another user. Comments?Yeah, I agree. Looks like a simple change in dbconnect(): /* * Use old password if no new one given (if you didn't have an old * one, fine) */ if (!pwparam && oldconn) pwparam = PQpass(oldconn);to /* * Use old password (if any) if no new one given and we are * reconnecting as same user */ if (!pwparam && oldconn && PQuser(oldconn) && userparam && strcmp(PQuser(oldconn), userparam) == 0) pwparam = PQpass(oldconn); regards, tom lane

1 parentb0c4598 commit78f7ba1Copy full SHA for 78f7ba1

File tree

1 file changed

-2

lines changed

src/bin/psql
- command.c

1 file changed

-2

lines changed

`‎src/bin/psql/command.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.59 2001/10/05 19:01:13 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.60 2001/10/11 16:54:18 momjian Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include"postgres_fe.h"`
`9`	`9`	`#include"command.h"`
`@@ -1287,7 +1287,8 @@ do_connect(const char new_dbname, const char new_user)`
`1287`	`1287`	`* Use old password if no new one given (if you didn't have an old`
`1288`	`1288`	`* one, fine)`
`1289`	`1289`	`*/`
`1290`		`-if (!pwparam&&oldconn)`
	`1290`	`+if (!pwparam&&oldconn&&PQuser(oldconn)&&userparam&&`
	`1291`	`+strcmp(PQuser(oldconn),userparam)==0)`
`1291`	`1292`	`pwparam=PQpass(oldconn);`
`1292`	`1293`
`1293`	`1294`	`do`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit78f7ba1

File tree

1 file changed

1 file changed

`‎src/bin/psql/command.c`

0 commit comments