Commit78d41f6

Amit Kapila

committed

Add missing assertions for required table am callbacks.

Reported-by: Ashwin AgrawalAuthor: Ashwin AgrawalReviewed-by: Amit KapilaBackpatch-through: 12, where it was introducedDiscussion:https://postgr.es/m/CALfoeisgdZhYDrJOukaBzvXfJOK2FQ0szVMK7dzmcy6w93iDUA@mail.gmail.com

1 parentcf20cc0 commit78d41f6Copy full SHA for 78d41f6

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ GetTableAmRoutine(Oid amhandler)`
`51`	`51`	`Assert(routine->scan_begin!=NULL);`
`52`	`52`	`Assert(routine->scan_end!=NULL);`
`53`	`53`	`Assert(routine->scan_rescan!=NULL);`
	`54`	`+Assert(routine->scan_getnextslot!=NULL);`
`54`	`55`
`55`	`56`	`Assert(routine->parallelscan_estimate!=NULL);`
`56`	`57`	`Assert(routine->parallelscan_initialize!=NULL);`
`@@ -62,7 +63,10 @@ GetTableAmRoutine(Oid amhandler)`
`62`	`63`	`Assert(routine->index_fetch_tuple!=NULL);`
`63`	`64`
`64`	`65`	`Assert(routine->tuple_fetch_row_version!=NULL);`
	`66`	`+Assert(routine->tuple_tid_valid!=NULL);`
	`67`	`+Assert(routine->tuple_get_latest_tid!=NULL);`
`65`	`68`	`Assert(routine->tuple_satisfies_snapshot!=NULL);`
	`69`	`+Assert(routine->compute_xid_horizon_for_tuples!=NULL);`
`66`	`70`
`67`	`71`	`Assert(routine->tuple_insert!=NULL);`
`68`	`72`
`@@ -89,6 +93,7 @@ GetTableAmRoutine(Oid amhandler)`
`89`	`93`	`Assert(routine->index_validate_scan!=NULL);`
`90`	`94`
`91`	`95`	`Assert(routine->relation_size!=NULL);`
	`96`	`+Assert(routine->relation_needs_toast_table!=NULL);`
`92`	`97`
`93`	`98`	`Assert(routine->relation_estimate_size!=NULL);`
`94`	`99`

Comments

(0)