forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit78c0b6e
committed
Re-allow testing of GiST buffered builds.
Commit16fa9b2 broke the ability to reliably test GiST buffered builds,because it caused sorted builds to be done instead if sortsupport isavailable, regardless of any attempt to override that. While a would-betest case could try to work around that by choosing an opclass that hasno sortsupport function, coverage would be silently lost the momentsomeone decides it'd be a good idea to add a sortsupport function.Hence, rearrange the logic in gistbuild() so that if "buffering = on"is specified in CREATE INDEX, we will use that method, sortsupport or no.Also document the interaction between sorting and the bufferingparameter, as16fa9b2 failed to do.(Note that in fact we still lack any test coverage of buffered builds,but this is a prerequisite to adding a non-fragile test.)Discussion:https://postgr.es/m/3249980.1602532990@sss.pgh.pa.us1 parent397ea90 commit78c0b6e
File tree
3 files changed
+77
-53
lines changed- doc/src/sgml
- ref
- src/backend/access/gist
3 files changed
+77
-53
lines changedLines changed: 37 additions & 21 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
975 | 975 |
| |
976 | 976 |
| |
977 | 977 |
| |
978 |
| - | |
| 978 | + | |
979 | 979 |
| |
980 | 980 |
| |
981 | 981 |
| |
| |||
987 | 987 |
| |
988 | 988 |
| |
989 | 989 |
| |
990 |
| - | |
| 990 | + | |
991 | 991 |
| |
992 | 992 |
| |
993 | 993 |
| |
| |||
1157 | 1157 |
| |
1158 | 1158 |
| |
1159 | 1159 |
| |
1160 |
| - | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
1161 | 1179 |
| |
1162 |
| - | |
1163 |
| - | |
1164 |
| - | |
1165 |
| - | |
1166 |
| - | |
1167 |
| - | |
1168 |
| - | |
1169 |
| - | |
1170 |
| - | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
1171 | 1186 |
| |
1172 | 1187 |
| |
1173 | 1188 |
| |
1174 |
| - | |
1175 |
| - | |
1176 |
| - | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
1177 | 1192 |
| |
1178 | 1193 |
| |
1179 | 1194 |
| |
1180 | 1195 |
| |
1181 | 1196 |
| |
1182 | 1197 |
| |
1183 | 1198 |
| |
1184 |
| - | |
1185 |
| - | |
1186 |
| - | |
1187 |
| - | |
1188 |
| - | |
1189 |
| - | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
1190 | 1206 |
| |
1191 | 1207 |
| |
1192 | 1208 |
| |
|
Lines changed: 8 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
463 | 463 |
| |
464 | 464 |
| |
465 | 465 |
| |
466 |
| - | |
| 466 | + | |
467 | 467 |
| |
468 |
| - | |
469 |
| - | |
470 |
| - | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
471 | 475 |
| |
472 | 476 |
| |
473 | 477 |
| |
|
Lines changed: 32 additions & 28 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
180 | 180 |
| |
181 | 181 |
| |
182 | 182 |
| |
183 |
| - | |
184 |
| - | |
185 |
| - | |
| 183 | + | |
186 | 184 |
| |
187 | 185 |
| |
188 | 186 |
| |
| |||
192 | 190 |
| |
193 | 191 |
| |
194 | 192 |
| |
195 |
| - | |
196 |
| - | |
197 |
| - | |
198 | 193 |
| |
199 | 194 |
| |
200 | 195 |
| |
| |||
208 | 203 |
| |
209 | 204 |
| |
210 | 205 |
| |
211 |
| - | |
212 |
| - | |
213 |
| - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
214 | 209 |
| |
215 |
| - | |
216 |
| - | |
217 |
| - | |
218 |
| - | |
219 |
| - | |
220 |
| - | |
221 |
| - | |
222 |
| - | |
223 |
| - | |
224 |
| - | |
225 |
| - | |
226 |
| - | |
227 |
| - | |
228 |
| - | |
229 |
| - | |
230 |
| - | |
231 |
| - | |
| 210 | + | |
232 | 211 |
| |
233 | 212 |
| |
234 | 213 |
| |
235 | 214 |
| |
236 | 215 |
| |
237 |
| - | |
| 216 | + | |
238 | 217 |
| |
239 | 218 |
| |
240 | 219 |
| |
241 | 220 |
| |
242 | 221 |
| |
243 | 222 |
| |
244 | 223 |
| |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
245 | 246 |
| |
246 | 247 |
| |
247 | 248 |
| |
| |||
852 | 853 |
| |
853 | 854 |
| |
854 | 855 |
| |
855 |
| - | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
856 | 860 |
| |
857 | 861 |
| |
858 | 862 |
| |
|
0 commit comments
Comments
(0)