NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit78aef14

committed

Fix time_part and timetz_part (ie, EXTRACT() for those datatypes) to

include a fractional part in the output for MILLISECOND and SECOND cases,rather than truncating the source value. This is what the float-timestampcode has always done, and it was clearly the code author's intent to dothe same for integer timestamps, but he forgot about integer division in C.The other datatypes supported by EXTRACT() already do this correctly.Backpatch to 8.4, so that the default (integer) behavior of that branch willmatch the default (float) behavior of older branches. Arguably we shouldpatch further back, but it's possible that applications are expecting thebroken behavior in older branches. 8.4 is new enough that expectationsshouldn't be too settled.Per report from Greg Stark.

1 parent25d9bf2 commit78aef14Copy full SHA for 78aef14

File tree

1 file changed

-7

lines changed

src/backend/utils/adt
- date.c

1 file changed

-7

lines changed

`‎src/backend/utils/adt/date.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/date.c,v 1.146 2009/06/11 14:49:03 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/date.c,v 1.147 2009/07/29 22:19:18 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1701,23 +1701,23 @@ time_part(PG_FUNCTION_ARGS)`
`1701`	`1701`	`{`
`1702`	`1702`	`caseDTK_MICROSEC:`
`1703`	`1703`	`#ifdefHAVE_INT64_TIMESTAMP`
`1704`		`-result=tm->tm_sec*USECS_PER_SEC+fsec;`
	`1704`	`+result=tm->tm_sec*1000000.0+fsec;`
`1705`	`1705`	`#else`
`1706`	`1706`	`result= (tm->tm_sec+fsec)*1000000;`
`1707`	`1707`	`#endif`
`1708`	`1708`	`break;`
`1709`	`1709`
`1710`	`1710`	`caseDTK_MILLISEC:`
`1711`	`1711`	`#ifdefHAVE_INT64_TIMESTAMP`
`1712`		`-result=tm->tm_sec*INT64CONST(1000)+fsec /INT64CONST(1000);`
	`1712`	`+result=tm->tm_sec*1000.0+fsec /1000.0;`
`1713`	`1713`	`#else`
`1714`	`1714`	`result= (tm->tm_sec+fsec)*1000;`
`1715`	`1715`	`#endif`
`1716`	`1716`	`break;`
`1717`	`1717`
`1718`	`1718`	`caseDTK_SECOND:`
`1719`	`1719`	`#ifdefHAVE_INT64_TIMESTAMP`
`1720`		`-result=tm->tm_sec+fsec /USECS_PER_SEC;`
	`1720`	`+result=tm->tm_sec+fsec /1000000.0;`
`1721`	`1721`	`#else`
`1722`	`1722`	`result=tm->tm_sec+fsec;`
`1723`	`1723`	`#endif`
`@@ -2469,23 +2469,23 @@ timetz_part(PG_FUNCTION_ARGS)`
`2469`	`2469`
`2470`	`2470`	`caseDTK_MICROSEC:`
`2471`	`2471`	`#ifdefHAVE_INT64_TIMESTAMP`
`2472`		`-result=tm->tm_sec*USECS_PER_SEC+fsec;`
	`2472`	`+result=tm->tm_sec*1000000.0+fsec;`
`2473`	`2473`	`#else`
`2474`	`2474`	`result= (tm->tm_sec+fsec)*1000000;`
`2475`	`2475`	`#endif`
`2476`	`2476`	`break;`
`2477`	`2477`
`2478`	`2478`	`caseDTK_MILLISEC:`
`2479`	`2479`	`#ifdefHAVE_INT64_TIMESTAMP`
`2480`		`-result=tm->tm_sec*INT64CONST(1000)+fsec /INT64CONST(1000);`
	`2480`	`+result=tm->tm_sec*1000.0+fsec /1000.0;`
`2481`	`2481`	`#else`
`2482`	`2482`	`result= (tm->tm_sec+fsec)*1000;`
`2483`	`2483`	`#endif`
`2484`	`2484`	`break;`
`2485`	`2485`
`2486`	`2486`	`caseDTK_SECOND:`
`2487`	`2487`	`#ifdefHAVE_INT64_TIMESTAMP`
`2488`		`-result=tm->tm_sec+fsec /USECS_PER_SEC;`
	`2488`	`+result=tm->tm_sec+fsec /1000000.0;`
`2489`	`2489`	`#else`
`2490`	`2490`	`result=tm->tm_sec+fsec;`
`2491`	`2491`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit78aef14

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/date.c`

0 commit comments