Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7886cc7

Browse files
committed
Remove "make check" target in src/test/isolation/Makefile.
This doesn't work as expected because the isolationtester program requireslibpq to already be installed. While it works when you've already installedlibpq, having to already have done "make install" defeats most of the pointof a check with a temp installation. And there are weird corner cases ifthe dynamic linker picks up an old libpq.so from system library directories.Remove the target (or more precisely, make it print a helpful message) sopeople don't expect the case to work.
1 parent78318d6 commit7886cc7

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

‎src/test/isolation/Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,10 @@ maintainer-clean: distclean
7272
installcheck: all
7373
./pg_isolation_regress --inputdir=$(srcdir) --schedule=$(srcdir)/isolation_schedule
7474

75-
check: all
76-
./pg_isolation_regress --temp-install=./tmp_check --inputdir=$(srcdir) --top-builddir=$(top_builddir) --schedule=$(srcdir)/isolation_schedule
75+
# We can't support "make check" because isolationtester requires libpq, and
76+
# in fact (on typical platforms using shared libraries) requires libpq to
77+
# already be installed. You could run "make install" and then run a check
78+
# using a temp installation, but there seems little point in that.
79+
check:
80+
@echo"'make check' is not supported."
81+
@echo"Install PostgreSQL, then 'make installcheck' instead."

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp