NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit787e20b

committed

Fix core dump in pg_dump --binary-upgrade on zero-column composite type.

This reverts nearly all of commit28f6cabin favor of just using the typrelid we already have in pg_dump's TypeInfostruct for the composite type. As coded, it'd crash if the composite typehad no attributes, since then the query would return no rows.Back-patch to all supported versions. It seems to not really be a problemin 9.0 because that version rejects the syntax "create type t as ()", butwe might as well keep the logic similar in all affected branches.Report and fix by Rushabh Lathia.

1 parent7c67b93 commit787e20bCopy full SHA for 787e20b

File tree

1 file changed

-9

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-9

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -8326,7 +8326,6 @@ dumpCompositeType(Archive fout, TypeInfo tyinfo)`
`8326`	`8326`	`inti_attalign;`
`8327`	`8327`	`inti_attisdropped;`
`8328`	`8328`	`inti_attcollation;`
`8329`		`-inti_typrelid;`
`8330`	`8329`	`inti;`
`8331`	`8330`	`intactual_atts;`
`8332`	`8331`
`@@ -8347,8 +8346,7 @@ dumpCompositeType(Archive fout, TypeInfo tyinfo)`
`8347`	`8346`	`"pg_catalog.format_type(a.atttypid, a.atttypmod) AS atttypdefn, "`
`8348`	`8347`	`"a.attlen, a.attalign, a.attisdropped, "`
`8349`	`8348`	`"CASE WHEN a.attcollation <> at.typcollation "`
`8350`		`-"THEN a.attcollation ELSE 0 END AS attcollation, "`
`8351`		`-"ct.typrelid "`
	`8349`	`+"THEN a.attcollation ELSE 0 END AS attcollation "`
`8352`	`8350`	`"FROM pg_catalog.pg_type ct "`
`8353`	`8351`	`"JOIN pg_catalog.pg_attribute a ON a.attrelid = ct.typrelid "`
`8354`	`8352`	`"LEFT JOIN pg_catalog.pg_type at ON at.oid = a.atttypid "`
`@@ -8366,8 +8364,7 @@ dumpCompositeType(Archive fout, TypeInfo tyinfo)`
`8366`	`8364`	`appendPQExpBuffer(query,"SELECT a.attname, "`
`8367`	`8365`	`"pg_catalog.format_type(a.atttypid, a.atttypmod) AS atttypdefn, "`
`8368`	`8366`	`"a.attlen, a.attalign, a.attisdropped, "`
`8369`		`-"0 AS attcollation, "`
`8370`		`-"ct.typrelid "`
	`8367`	`+"0 AS attcollation "`
`8371`	`8368`	`"FROM pg_catalog.pg_type ct, pg_catalog.pg_attribute a "`
`8372`	`8369`	`"WHERE ct.oid = '%u'::pg_catalog.oid "`
`8373`	`8370`	`"AND a.attrelid = ct.typrelid "`
`@@ -8385,15 +8382,12 @@ dumpCompositeType(Archive fout, TypeInfo tyinfo)`
`8385`	`8382`	`i_attalign=PQfnumber(res,"attalign");`
`8386`	`8383`	`i_attisdropped=PQfnumber(res,"attisdropped");`
`8387`	`8384`	`i_attcollation=PQfnumber(res,"attcollation");`
`8388`		`-i_typrelid=PQfnumber(res,"typrelid");`
`8389`	`8385`
`8390`	`8386`	`if (binary_upgrade)`
`8391`	`8387`	`{`
`8392`		`-Oidtyprelid=atooid(PQgetvalue(res,0,i_typrelid));`
`8393`		`-`
`8394`	`8388`	`binary_upgrade_set_type_oids_by_type_oid(fout,q,`
`8395`	`8389`	`tyinfo->dobj.catId.oid);`
`8396`		`-binary_upgrade_set_pg_class_oids(fout,q,typrelid, false);`
	`8390`	`+binary_upgrade_set_pg_class_oids(fout,q,tyinfo->typrelid, false);`
`8397`	`8391`	`}`
`8398`	`8392`
`8399`	`8393`	`qtypname=pg_strdup(fmtId(tyinfo->dobj.name));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit787e20b

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments