forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit783d8ab
committed
Fix behavior with pg_restore -l and compressed dumps
pg_restore -l has always been able to read the TOC data of a dump evenif its binary has no support for compression, for both compressed anduncompressed dumps.5e73a60 has introduced a backward-incompatiblebehavior by switching a warning to a hard error in the code path readingthe header data of a dump, preventing the TOC items to be listed even ifpg_restore -l, with no support for compression, is used on a compresseddump. Most modern systems should have support for zlib, but it can bealso possible that somebody relies on the past behavior when copyingover a dump where binaries are not built with zlib support (most likelysome WIN32 flavors these days, though most environments should providethat).There is no easy way to have a regression test for this pattern, as itrequires a mix of dump/restore commands with different compilationoptions, with and without compression. One possibility I see here wouldbe to have a command-line option that enforces a non-compression checkfor a build that supports compression, but that does not seem worth thecost, either.Reported-by: Justin PryzbyAuthor: Georgios KokolatosDiscussion:https://postgr.es/m/20230125180020.GF22427@telsasoft.com1 parent3a28d78 commit783d8ab
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3784 | 3784 | | |
3785 | 3785 | | |
3786 | 3786 | | |
3787 | | - | |
| 3787 | + | |
3788 | 3788 | | |
3789 | 3789 | | |
3790 | 3790 | | |
| |||
0 commit comments
Comments
(0)