forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit77c1d92
committed
Un-break whole-row Vars referencing domain-over-composite types.
In commitec62cb0, I foolishly replaced ExecEvalWholeRowVar'slookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc,because I didn't see how a domain could be involved there, andthere were no regression test cases to jog my memory. But theexisting code was correct, so revert that change and add a testcase showing why it's necessary. (Note: per comment in structDatumTupleFields, it is correct to produce an output tuple that'slabeled with the base composite type, not the domain; hence justblindly looking through the domain is correct here.)Per bug #17515 from Dan Kubb. Back-patch to v11 where domains overcomposites became a thing.Discussion:https://postgr.es/m/17515-a24737438363aca0@postgresql.org1 parent0ccef41 commit77c1d92
File tree
3 files changed
+37
-1
lines changed- src
- backend/executor
- test/regress
- expected
- sql
3 files changed
+37
-1
lines changedLines changed: 5 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4008 | 4008 |
| |
4009 | 4009 |
| |
4010 | 4010 |
| |
| 4011 | + | |
| 4012 | + | |
| 4013 | + | |
4011 | 4014 |
| |
4012 |
| - | |
| 4015 | + | |
| 4016 | + | |
4013 | 4017 |
| |
4014 | 4018 |
| |
4015 | 4019 |
| |
|
Lines changed: 23 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
277 | 277 |
| |
278 | 278 |
| |
279 | 279 |
| |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
280 | 303 |
| |
281 | 304 |
| |
282 | 305 |
| |
|
Lines changed: 9 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
154 | 154 |
| |
155 | 155 |
| |
156 | 156 |
| |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
157 | 166 |
| |
158 | 167 |
| |
159 | 168 |
| |
|
0 commit comments
Comments
(0)