NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit77ba610

committed

Revert "Use Foreign Key relationships to infer multi-column join selectivity".

This commit reverts137805f as well as the associated commits015e889,5306df2, and68d704e. We found multiple bugs in this feature, andthere was concern about possible planner slowdown (though to be fair,exhibiting a very large slowdown proved difficult). The way forwardrequires a considerable rewrite, which may or may not be possible toaccomplish in time for beta2. In my judgment reviewing the rewrite willbe easier to accomplish starting from a clean slate, so let's temporarilyrevert what's there now. This also leaves us in a safe state if it turnsout to be necessary to postpone the rewrite to the next development cycle.Discussion: <20160429102531.GA13701@huehner.biz>

1 parent5c6d2a5 commit77ba610Copy full SHA for 77ba610

File tree

12 files changed

+25

-591

lines changed

src
- backend
  - nodes
    - outfuncs.c
  - optimizer
    - path
      - costsize.c
    - util
      - plancat.c
  - utils
    - cache
      - relcache.c
    - misc
      - guc.c
- include
  - nodes
    - nodes.h
    - relation.h
  - optimizer
    - cost.h
    - paths.h
  - utils
    - rel.h
    - relcache.h
- test/regress/expected
  - rangefuncs.out

12 files changed

+25

-591

lines changed

`‎src/backend/nodes/outfuncs.c`

Lines changed: 0 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -2137,16 +2137,6 @@ _outIndexOptInfo(StringInfo str, const IndexOptInfo *node)`
`2137`	`2137`	`/* we don't bother with fields copied from the index AM's API struct */`
`2138`	`2138`	`}`
`2139`	`2139`
`2140`		`-staticvoid`
`2141`		`-_outForeignKeyOptInfo(StringInfostr,constForeignKeyOptInfo*node)`
`2142`		`-{`
`2143`		`-WRITE_NODE_TYPE("FOREIGNKEYOPTINFO");`
`2144`		`-`
`2145`		`-WRITE_OID_FIELD(conrelid);`
`2146`		`-WRITE_OID_FIELD(confrelid);`
`2147`		`-WRITE_INT_FIELD(nkeys);`
`2148`		`-}`
`2149`		`-`
`2150`	`2140`	`staticvoid`
`2151`	`2141`	`_outEquivalenceClass(StringInfostr,constEquivalenceClass*node)`
`2152`	`2142`	`{`
`@@ -3617,9 +3607,6 @@ outNode(StringInfo str, const void *obj)`
`3617`	`3607`	`caseT_IndexOptInfo:`
`3618`	`3608`	`_outIndexOptInfo(str,obj);`
`3619`	`3609`	`break;`
`3620`		`-caseT_ForeignKeyOptInfo:`
`3621`		`-_outForeignKeyOptInfo(str,obj);`
`3622`		`-break;`
`3623`	`3610`	`caseT_EquivalenceClass:`
`3624`	`3611`	`_outEquivalenceClass(str,obj);`
`3625`	`3612`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit77ba610

File tree

12 files changed

12 files changed

`‎src/backend/nodes/outfuncs.c`

0 commit comments