NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit77642a8

committed

Remove special cases for ETXTBSY from new fsync'ing logic.

The argument that this is a sufficiently-expected case to be silentlyignored seems pretty thin. Andres had brought it up back when we werestill considering that most fsync failures should be hard errors, and itprobably would be legit not to fail hard for ETXTBSY --- but the same istrue for EROFS and other cases, which is why we gave up on hard failures.ETXTBSY is surely not a normal case, so logging the failure seems finefrom here.

1 parentaa8377e commit77642a8Copy full SHA for 77642a8

File tree

1 file changed

-12

lines changed

src/backend/storage/file
- fd.c

1 file changed

-12

lines changed

`‎src/backend/storage/file/fd.c`

Lines changed: 3 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -2477,18 +2477,15 @@ pre_sync_fname(const char *fname, bool isdir, int elevel)`
`2477`	`2477`	`{`
`2478`	`2478`	`if (errno==EACCES\|\| (isdir&&errno==EISDIR))`
`2479`	`2479`	`return;`
`2480`		`-`
`2481`		`-#ifdefETXTBSY`
`2482`		`-if (errno==ETXTBSY)`
`2483`		`-return;`
`2484`		`-#endif`
`2485`		`-`
`2486`	`2480`	`ereport(elevel,`
`2487`	`2481`	`(errcode_for_file_access(),`
`2488`	`2482`	`errmsg("could not open file \"%s\": %m",fname)));`
`2489`	`2483`	`return;`
`2490`	`2484`	`}`
`2491`	`2485`
	`2486`	`+/*`
	`2487`	`+ * We ignore errors from pg_flush_data() because this is only a hint.`
	`2488`	`+ */`
`2492`	`2489`	`(void)pg_flush_data(fd,0,0);`
`2493`	`2490`
`2494`	`2491`	`(void)close(fd);`
`@@ -2532,12 +2529,6 @@ fsync_fname_ext(const char *fname, bool isdir, int elevel)`
`2532`	`2529`	`{`
`2533`	`2530`	`if (errno==EACCES\|\| (isdir&&errno==EISDIR))`
`2534`	`2531`	`return;`
`2535`		`-`
`2536`		`-#ifdefETXTBSY`
`2537`		`-if (errno==ETXTBSY)`
`2538`		`-return;`
`2539`		`-#endif`
`2540`		`-`
`2541`	`2532`	`ereport(elevel,`
`2542`	`2533`	`(errcode_for_file_access(),`
`2543`	`2534`	`errmsg("could not open file \"%s\": %m",fname)));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit77642a8

File tree

1 file changed

1 file changed

`‎src/backend/storage/file/fd.c`

0 commit comments