forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit7715a3c
committed
Prevent clobbering of utility statements in SQL function caches.
This is an oversight in commit7c337b6: I apparently didn't thinkabout the possibility of a SQL function being executed multipletimes within a query. In that case, functions.c's primitive cachingmechanism allows the same utility parse tree to be presented forexecution more than once. We have to tell ProcessUtility to makea working copy of the parse tree, or bad things happen.Normally I'd add a regression test, but I think the reported crasheris dependent on some rather random implementation choices that arenowhere near functions.c, so its usefulness as a long-lived testfeels questionable. In any case, this fix is clearly correct giventhe design choices of7c337b6.Per bug #17702 from Xin Wen. Thanks to Daniel Gustafsson foranalysis. Back-patch to v14 where the faulty commit came in(before that, the responsibility for copying scribble-ableutility parse trees lay elsewhere).Discussion:https://postgr.es/m/17702-ad24fdcdd1e9047a@postgresql.org1 parent0224646 commit7715a3c
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
886 | 886 | | |
887 | 887 | | |
888 | 888 | | |
889 | | - | |
| 889 | + | |
890 | 890 | | |
891 | 891 | | |
892 | 892 | | |
| |||
0 commit comments
Comments
(0)