NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7685963

committed

Handle PQresultErrorField(PG_DIAG_SQLSTATE) returning NULL in streamutil.c.

Inff27db5 I missed that PQresultErrorField() may return NULL ifthere's no sqlstate associated with an error.Spotted-By: CoverityReported-By: Michael PaquierDiscussion: CAB7nPqQ3o10SY6NVdU4pjq85GQTN5tbbkq2gnNUh2fBNU3rKyQ@mail.gmail.comBackpatch: 9.5, likeff27db5

1 parentd25fbf9 commit7685963Copy full SHA for 7685963

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- streamutil.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/streamutil.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,9 @@ CreateReplicationSlot(PGconn conn, const char slot_name, const char *plugin,`
`340`	`340`	`{`
`341`	`341`	`constchar*sqlstate=PQresultErrorField(res,PG_DIAG_SQLSTATE);`
`342`	`342`
`343`		`-if (slot_exists_ok&&strcmp(sqlstate,ERRCODE_DUPLICATE_OBJECT)==0)`
	`343`	`+if (slot_exists_ok&&`
	`344`	`+sqlstate&&`
	`345`	`+strcmp(sqlstate,ERRCODE_DUPLICATE_OBJECT)==0)`
`344`	`346`	`{`
`345`	`347`	`destroyPQExpBuffer(query);`
`346`	`348`	`PQclear(res);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7685963

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/streamutil.c`

0 commit comments