NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit765ad89

committed

Use InvalidSnapshot, now SnapshotNow, as the default snapshot.

As far as I can determine, there's no code in the core distributionthat fails to explicitly set the snapshot of a scan or executorstate. If there is any such code, this will probably cause it toseg fault; friendlier suggestions were discussed on pgsql-hackers,but there was no consensus that anything more than this wasneeded.This is another step towards the hoped-for complete removal ofSnapshotNow.

1 parente605506 commit765ad89Copy full SHA for 765ad89

File tree

2 files changed

-2

lines changed

src/backend
- access/index
  - genam.c
- executor
  - execUtils.c

2 files changed

-2

lines changed

`‎src/backend/access/index/genam.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ RelationGetIndexScan(Relation indexRelation, int nkeys, int norderbys)`
`79`	`79`
`80`	`80`	`scan->heapRelation=NULL;/* may be set later */`
`81`	`81`	`scan->indexRelation=indexRelation;`
`82`		`-scan->xs_snapshot=SnapshotNow;/may be set later /`
	`82`	`+scan->xs_snapshot=InvalidSnapshot;/caller must initialize this /`
`83`	`83`	`scan->numberOfKeys=nkeys;`
`84`	`84`	`scan->numberOfOrderBys=norderbys;`
`85`	`85`

`‎src/backend/executor/execUtils.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ CreateExecutorState(void)`
`105`	`105`	`* Initialize all fields of the Executor State structure`
`106`	`106`	`*/`
`107`	`107`	`estate->es_direction=ForwardScanDirection;`
`108`		`-estate->es_snapshot=SnapshotNow;`
	`108`	`+estate->es_snapshot=InvalidSnapshot;/* caller must initialize this */`
`109`	`109`	`estate->es_crosscheck_snapshot=InvalidSnapshot;/* no crosscheck */`
`110`	`110`	`estate->es_range_table=NIL;`
`111`	`111`	`estate->es_plannedstmt=NULL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit765ad89

File tree

2 files changed

2 files changed

`‎src/backend/access/index/genam.c`

`‎src/backend/executor/execUtils.c`

0 commit comments