NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit75c35e0

committed

Remove check on source address of a statistics packet. Check was broken

by recent IPv6 changes, and since it's redundant with a kernel-level checkanyway, it seems not worth trying to fix it. Per recent discussions.

1 parent4b407f6 commit75c35e0Copy full SHA for 75c35e0

File tree

1 file changed

-17

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

-17

lines changed

`‎src/backend/postmaster/pgstat.c‎`

Lines changed: 3 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`*Copyright (c) 2001-2003, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`		`- *$Header: /cvsroot/pgsql/src/backend/postmaster/pgstat.c,v 1.43 2003/08/12 16:21:18 tgl Exp $`
	`16`	`+ *$Header: /cvsroot/pgsql/src/backend/postmaster/pgstat.c,v 1.44 2003/09/07 14:44:40 tgl Exp $`
`17`	`17`	`* ----------`
`18`	`18`	`*/`
`19`	`19`	`#include"postgres.h"`
`@@ -1591,8 +1591,6 @@ pgstat_recvbuffer(void)`
`1591`	`1591`	`intmsg_send=0;/* next send index in buffer */`
`1592`	`1592`	`intmsg_recv=0;/* next receive index */`
`1593`	`1593`	`intmsg_have=0;/* number of bytes stored */`
`1594`		`-structsockaddr_storagefromaddr;`
`1595`		`-intfromlen;`
`1596`	`1594`	`booloverflow= false;`
`1597`	`1595`
`1598`	`1596`	`/*`
`@@ -1702,10 +1700,8 @@ pgstat_recvbuffer(void)`
`1702`	`1700`	`*/`
`1703`	`1701`	`if (FD_ISSET(pgStatSock,&rfds))`
`1704`	`1702`	`{`
`1705`		`-fromlen=sizeof(fromaddr);`
`1706`		`-len=recvfrom(pgStatSock, (char*)&input_buffer,`
`1707`		`-sizeof(PgStat_Msg),0,`
`1708`		`- (structsockaddr*)&fromaddr,&fromlen);`
	`1703`	`+len=recv(pgStatSock, (char*)&input_buffer,`
	`1704`	`+sizeof(PgStat_Msg),0);`
`1709`	`1705`	`if (len<0)`
`1710`	`1706`	`{`
`1711`	`1707`	`ereport(LOG,`
`@@ -1726,16 +1722,6 @@ pgstat_recvbuffer(void)`
`1726`	`1722`	`if (input_buffer.msg_hdr.m_size!=len)`
`1727`	`1723`	`continue;`
`1728`	`1724`
`1729`		`-/*`
`1730`		`- * The source address of the packet must be our own socket.`
`1731`		`- * This ensures that only real hackers or our own backends`
`1732`		`- * tell us something. (This should be redundant with a`
`1733`		`- * kernel-level check due to having used connect(), but let's`
`1734`		`- * do it anyway.)`
`1735`		`- */`
`1736`		`-if (memcmp(&fromaddr,&pgStatAddr,fromlen))`
`1737`		`-continue;`
`1738`		`-`
`1739`	`1725`	`/*`
`1740`	`1726`	`* O.K. - we accept this message. Copy it to the circular`
`1741`	`1727`	`* msgbuffer.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit75c35e0

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c‎`

0 commit comments