Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit75a006b

Browse files
committed
Remove some recently-added pg_dump test cases.
Commitd2d3547 included a prettyextensive set of test cases, and some of them don't work on allof our Windows machines. This happens because IPC::Run expandsits arguments as shell globs on a few machines, but doesn't on mostof the buildfarm. It might be good to fix that problem systematicallysomehow, but in the meantime, there are enough test cases for thiscommit that it seems OK to just remove the ones that are failing.Discussion:http://postgr.es/m/3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.netDiscussion:http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com
1 parentdff6c77 commit75a006b

File tree

1 file changed

+2
-32
lines changed

1 file changed

+2
-32
lines changed

‎src/bin/pg_dump/t/002_pg_dump.pl

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -3601,8 +3601,8 @@
36013601
$node->psql('postgres', 'create database regress_pg_dump_test;');
36023602
36033603
# Start with number of command_fails_like()*2 tests below (each
3604-
# command_fails_like is actually 2 tests)
3605-
my$num_tests =42;
3604+
# command_fails_like is actually 2 tests) + number of command_ok()*3
3605+
my$num_tests =33;
36063606
36073607
foreach my$run (sort keys%pgdump_runs)
36083608
{
@@ -3784,18 +3784,6 @@
37843784
'pg_dumpall: option --exclude-database rejects multipart pattern "."'
37853785
);
37863786
3787-
command_fails_like(
3788-
[ 'pg_dumpall', '-p', "$port", '--exclude-database', '.*' ],
3789-
qr/pg_dumpall: error: improper qualified name\(too many dotted names\):\.\*/,
3790-
'pg_dumpall: option --exclude-database rejects multipart pattern ".*"'
3791-
);
3792-
3793-
command_fails_like(
3794-
[ 'pg_dumpall', '-p', "$port", '--exclude-database', '*.*' ],
3795-
qr/pg_dumpall: error: improper qualified name\(too many dotted names\):\*\.\*/,
3796-
'pg_dumpall: option --exclude-database rejects multipart pattern "*.*"'
3797-
);
3798-
37993787
command_fails_like(
38003788
[ 'pg_dumpall', '-p', "$port", '--exclude-database', 'myhost.mydb' ],
38013789
qr/pg_dumpall: error: improper qualified name\(too many dotted names\): myhost\.mydb/,
@@ -3810,12 +3798,6 @@
38103798
'pg_dumpall: option --exclude-database handles database names with embedded dots'
38113799
);
38123800
3813-
$node->command_ok(
3814-
[ 'pg_dumpall', '-p', "$port", '--exclude-database', '??*' ],
3815-
'pg_dumpall: option --exclude-database handles database name patterns'
3816-
);
3817-
3818-
38193801
#########################################
38203802
# Test invalid multipart schema names
38213803
@@ -3843,24 +3825,12 @@
38433825
'pg_dump: option --schema rejects degenerate two-part schema name: "."'
38443826
);
38453827
3846-
command_fails_like(
3847-
[ 'pg_dump', '-p', "$port", '--schema', '.*' ],
3848-
qr/pg_dump: error: cross-database references are not implemented:\.\*/,
3849-
'pg_dump: option --schema rejects degenerate two-part schema name: ".*"'
3850-
);
3851-
38523828
command_fails_like(
38533829
[ 'pg_dump', '-p', "$port", '--schema', '..' ],
38543830
qr/pg_dump: error: improper qualified name\(too many dotted names\):\.\./,
38553831
'pg_dump: option --schema rejects degenerate three-part schema name: ".."'
38563832
);
38573833
3858-
command_fails_like(
3859-
[ 'pg_dump', '-p', "$port", '--schema', '.*.*' ],
3860-
qr/pg_dump: error: improper qualified name\(too many dotted names\):\.\*\.\*/,
3861-
'pg_dump: option --schema rejects degenerate three-part schema pattern: ".*.*"'
3862-
);
3863-
38643834
#########################################
38653835
# Test invalid multipart relation names
38663836

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp