NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7570df0

committed

Improve what pg_strsignal prints if we haven't got strsignal(3).

Turns out that returning "unrecognized signal" is confusing.Make it explicit that the platform lacks any support for signal names.(At least of the machines in the buildfarm, only HPUX lacks it.)Back-patch to v12 where we invented this function.Discussion:https://postgr.es/m/3067.1566870481@sss.pgh.pa.us

1 parentc0222c2 commit7570df0Copy full SHA for 7570df0

File tree

1 file changed

-8

lines changed

src/port
- pgstrsignal.c

1 file changed

-8

lines changed

`‎src/port/pgstrsignal.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,11 @@`
`32`	`32`	`*`
`33`	`33`	`* This version guarantees to return a non-NULL pointer, although`
`34`	`34`	`* some platforms' versions of strsignal() reputedly do not.`
	`35`	`+ *`
	`36`	`+ * Note that the fallback cases just return constant strings such as`
	`37`	`+ * "unrecognized signal". Project style is for callers to print the`
	`38`	`+ * numeric signal value along with the result of this function, so`
	`39`	`+ * there's no need to work harder than that.`
`35`	`40`	`*/`
`36`	`41`	`constchar*`
`37`	`42`	`pg_strsignal(intsignum)`
`@@ -43,22 +48,17 @@ pg_strsignal(int signum)`
`43`	`48`	`*/`
`44`	`49`	`#ifdefHAVE_STRSIGNAL`
`45`	`50`	`result=strsignal(signum);`
`46`		`-if (result)`
`47`		`-returnresult;`
	`51`	`+if (result==NULL)`
	`52`	`+result="unrecognized signal";`
`48`	`53`	`#else`
`49`	`54`
`50`	`55`	`/*`
`51`	`56`	`* We used to have code here to try to use sys_siglist[] if available.`
`52`	`57`	`* However, it seems that all platforms with sys_siglist[] have also had`
`53`	`58`	`* strsignal() for many years now, so that was just a waste of code.`
`54`	`59`	`*/`
	`60`	`+result="(signal names not available on this platform)";`
`55`	`61`	`#endif`
`56`	`62`
`57`		`-/*`
`58`		`- * Fallback case: just return "unrecognized signal". Project style is for`
`59`		`- * callers to print the numeric signal value along with the result of this`
`60`		`- * function, so there's no need to work harder than this.`
`61`		`- */`
`62`		`-result="unrecognized signal";`
`63`	`63`	`returnresult;`
`64`	`64`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7570df0

File tree

1 file changed

1 file changed

`‎src/port/pgstrsignal.c`

0 commit comments