NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit75680c3

committed

Retire a few backwards compatibility macros.

As of commitsdd04e95 and1833f1a, tuplestore_donestoring(),SPI_push(), SPI_pop(), SPI_push_conditional(),SPI_pop_conditional(), and SPI_restore_connection() are no-opmacros provided for backwards compatibility. This commit removesthese macros, so any uses in third-party code will need to beremoved, too. Since these macros have been no-ops for a while,such adjustments won't produce any behavior changes for allcurrently-supported versions of PostgreSQL.Author: Bharath RupireddyDiscussion:https://postgr.es/m/CALj2ACVeO58JM5tK2Qa8QC-%3DkC8sdkJOTd4BFU%3DK8zs4gGYpjQ%40mail.gmail.com

1 parent8a553f2 commit75680c3Copy full SHA for 75680c3

File tree

2 files changed

-10

lines changed

src/include
- executor
  - spi.h
- utils
  - tuplestore.h

2 files changed

-10

lines changed

`‎src/include/executor/spi.h`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,13 +100,6 @@ typedef struct _SPI_plan *SPIPlanPtr;`
`100`	`100`
`101`	`101`	`#defineSPI_OPT_NONATOMIC(1 << 0)`
`102`	`102`
`103`		`-/* These used to be functions, now just no-ops for backwards compatibility */`
`104`		`-#defineSPI_push()((void) 0)`
`105`		`-#defineSPI_pop()((void) 0)`
`106`		`-#defineSPI_push_conditional()false`
`107`		`-#defineSPI_pop_conditional(pushed) ((void) 0)`
`108`		`-#defineSPI_restore_connection()((void) 0)`
`109`		`-`
`110`	`103`	`externPGDLLIMPORTuint64SPI_processed;`
`111`	`104`	`externPGDLLIMPORTSPITupleTable*SPI_tuptable;`
`112`	`105`	`externPGDLLIMPORTintSPI_result;`

`‎src/include/utils/tuplestore.h`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,6 @@ extern void tuplestore_puttuple(Tuplestorestate *state, HeapTuple tuple);`
`56`	`56`	`externvoidtuplestore_putvalues(Tuplestorestate*state,TupleDesctdesc,`
`57`	`57`	`constDatumvalues,constboolisnull);`
`58`	`58`
`59`		`-/* Backwards compatibility macro */`
`60`		`-#definetuplestore_donestoring(state)((void) 0)`
`61`		`-`
`62`	`59`	`externinttuplestore_alloc_read_pointer(Tuplestorestate*state,inteflags);`
`63`	`60`
`64`	`61`	`externvoidtuplestore_select_read_pointer(Tuplestorestate*state,intptr);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit75680c3

File tree

2 files changed

2 files changed

`‎src/include/executor/spi.h`

`‎src/include/utils/tuplestore.h`

0 commit comments