NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7516056

committed

Attempt to stabilize new window agg regression test

This test was recently added in3900a02. It appears to be unstable inregards to the join order presumably due to the relations at either sideof the join being equal in side. Here we add a qual to make one of themsmaller so the planner is more likely to choose to hash the smaller of thetwo.Reported-by: Nathan Bossart, Tom LaneDiscussion:https://www.postgr.es/m/20230803235403.GC1238296@nathanxps13

1 parent3fd19a9 commit7516056Copy full SHA for 7516056

File tree

2 files changed

-4

lines changed

src/test/regress
- expected
  - window.out
- sql
  - window.sql

2 files changed

-4

lines changed

`‎src/test/regress/expected/window.out`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4834,17 +4834,19 @@ LIMIT 1;`
`4834`	`4834`	`EXPLAIN (COSTS OFF)`
`4835`	`4835`	`SELECT COUNT(*) OVER ()`
`4836`	`4836`	`FROM tenk1 t1 INNER JOIN tenk1 t2 ON t1.unique1 = t2.tenthous`
	`4837`	`+WHERE t2.two = 1`
`4837`	`4838`	`LIMIT 1;`
`4838`		`-QUERY PLAN`
`4839`		`---------------------------------------------------------------------------------`
	`4839`	`+ QUERY PLAN`
	`4840`	`+-------------------------------------------------------------------`
`4840`	`4841`	`Limit`
`4841`	`4842`	`-> WindowAgg`
`4842`	`4843`	`-> Hash Join`
`4843`	`4844`	`Hash Cond: (t1.unique1 = t2.tenthous)`
`4844`	`4845`	`-> Index Only Scan using tenk1_unique1 on tenk1 t1`
`4845`	`4846`	`-> Hash`
`4846`		`- -> Index Only Scan using tenk1_thous_tenthous on tenk1 t2`
`4847`		`-(7 rows)`
	`4847`	`+ -> Seq Scan on tenk1 t2`
	`4848`	`+ Filter: (two = 1)`
	`4849`	`+(8 rows)`
`4848`	`4850`
`4849`	`4851`	`-- Ensure we get a cheap total plan. This time use UNBOUNDED FOLLOWING, which`
`4850`	`4852`	`-- needs to read all join rows to output the first WindowAgg row.`

`‎src/test/regress/sql/window.sql`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1734,6 +1734,7 @@ LIMIT 1;`
`1734`	`1734`	`EXPLAIN (COSTS OFF)`
`1735`	`1735`	`SELECTCOUNT(*) OVER ()`
`1736`	`1736`	`FROM tenk1 t1INNER JOIN tenk1 t2ONt1.unique1=t2.tenthous`
	`1737`	`+WHEREt2.two=1`
`1737`	`1738`	`LIMIT1;`
`1738`	`1739`
`1739`	`1740`	`-- Ensure we get a cheap total plan. This time use UNBOUNDED FOLLOWING, which`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7516056

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/window.out`

`‎src/test/regress/sql/window.sql`

0 commit comments