Commit74ef810

committed

Fix embarrassing bug in recent smgr refactoring patch: WAL records should

be written for *non*-temp tables only. Report and test case by MarkKirkwood and Simon Riggs.

1 parenta65ed83 commit74ef810Copy full SHA for 74ef810

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/storage.c,v 1.3 2009/01/01 17:23:37 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/storage.c,v 1.4 2009/01/04 14:59:22 heikki Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* Some of this code used to be in storage/smgr/smgr.c, and the`
`@@ -106,7 +106,7 @@ RelationCreateStorage(RelFileNode rnode, bool istemp)`
`106`	`106`	`srel=smgropen(rnode);`
`107`	`107`	`smgrcreate(srel,MAIN_FORKNUM, false);`
`108`	`108`
`109`		`-if (istemp)`
	`109`	`+if (!istemp)`
`110`	`110`	`{`
`111`	`111`	`/*`
`112`	`112`	`* Make an XLOG entry showing the file creation. If we abort, the file`
`@@ -203,7 +203,7 @@ RelationTruncate(Relation rel, BlockNumber nblocks)`
`203`	`203`	`* harmless failure to truncate, that could spell trouble at WAL replay,`
`204`	`204`	`* into a certain PANIC.`
`205`	`205`	`*/`
`206`		`-if (rel->rd_istemp)`
	`206`	`+if (!rel->rd_istemp)`
`207`	`207`	`{`
`208`	`208`	`/*`
`209`	`209`	`* Make an XLOG entry showing the file truncation.`

Comments

(0)