Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit74cf802

Browse files
committed
Assert that strong-lock count is >0 everywhere it's decremented.
The one existing assertion of this type has tripped a few times in thebuildfarm lately, but it's not clear whether the problem is reallyoriginating there or whether it's leftovers from a trip through oneof the other two paths that lack a matching assertion. So add one.Since the same bug(s) most likely exist(s) in the back-branches also,back-patch to 9.2, where the fast-path lock mechanism was added.
1 parent53463e2 commit74cf802

File tree

1 file changed

+2
-0
lines changed
  • src/backend/storage/lmgr

1 file changed

+2
-0
lines changed

‎src/backend/storage/lmgr/lock.c‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1516,6 +1516,7 @@ AbortStrongLockAcquire(void)
15161516
fasthashcode=FastPathStrongLockHashPartition(locallock->hashcode);
15171517
Assert(locallock->holdsStrongLockCount== TRUE);
15181518
SpinLockAcquire(&FastPathStrongRelationLocks->mutex);
1519+
Assert(FastPathStrongRelationLocks->count[fasthashcode]>0);
15191520
FastPathStrongRelationLocks->count[fasthashcode]--;
15201521
locallock->holdsStrongLockCount= FALSE;
15211522
StrongLockInProgress=NULL;
@@ -2882,6 +2883,7 @@ LockRefindAndRelease(LockMethod lockMethodTable, PGPROC *proc,
28822883
uint32fasthashcode=FastPathStrongLockHashPartition(hashcode);
28832884

28842885
SpinLockAcquire(&FastPathStrongRelationLocks->mutex);
2886+
Assert(FastPathStrongRelationLocks->count[fasthashcode]>0);
28852887
FastPathStrongRelationLocks->count[fasthashcode]--;
28862888
SpinLockRelease(&FastPathStrongRelationLocks->mutex);
28872889
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp