Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit74ca8f9

Browse files
committed
Fix pg_basebackup test to original intent
One test case was meant to check that pg_basebackup does not succeedwhen a slot is specified with -S but WAL streaming is not selected,which used to require specifying -X stream. Since -X stream is thedefault in PostgreSQL 10, this test case no longer covers that meaning,but the pg_basebackup invocation happened to fail anyway for theunrelated reason that the specified replication slot does not exist. Tofix, move the test case to later in the file where the slot does exist,and add -X none to the invocation so that it covers the originally meantbehavior.extracted from a patch by Michael Banck <michael.banck@credativ.de>
1 parent24541ff commit74ca8f9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

‎src/bin/pg_basebackup/t/010_pg_basebackup.pl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,6 @@
255255
'stream','--no-slot' ],
256256
'pg_basebackup -X stream runs with --no-slot');
257257

258-
$node->command_fails(
259-
['pg_basebackup','-D',"$tempdir/fail",'-S','slot1' ],
260-
'pg_basebackup with replication slot fails without -X stream');
261258
$node->command_fails(
262259
['pg_basebackup','-D',
263260
"$tempdir/backupxs_sl_fail",'-X',
@@ -271,6 +268,9 @@
271268
q{SELECT restart_lsn FROM pg_replication_slots WHERE slot_name = 'slot1'}
272269
);
273270
is($lsn,'','restart LSN of new slot is null');
271+
$node->command_fails(
272+
['pg_basebackup','-D',"$tempdir/fail",'-S','slot1','-X','none' ],
273+
'pg_basebackup with replication slot fails without WAL streaming');
274274
$node->command_ok(
275275
['pg_basebackup','-D',"$tempdir/backupxs_sl",'-X',
276276
'stream','-S','slot1' ],

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp