Commit74b7cc8

committed

Fix misleading comment in nodeIndexonlyscan.c.

The stated reason for acquiring predicate locks on heap pages hasn'texisted since commitc01262a, so fix the comment. Perhaps in a laterrelease we'll also be able to change the code to use tuple locks.Back-patch all the way.Reviewed-by: Ashwin AgrawalDiscussion:https://postgr.es/m/CAEepm%3D2GK3FVdnt5V3d%2Bh9njWipCv_fNL%3DwjxyUhzsF%3D0PcbNg%40mail.gmail.com

1 parent69fd82f commit74b7cc8Copy full SHA for 74b7cc8

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -242,11 +242,8 @@ IndexOnlyNext(IndexOnlyScanState *node)`
`242`	`242`	`errmsg("lossy distance functions are not supported in index-only scans")));`
`243`	`243`
`244`	`244`	`/*`
`245`		`- * Predicate locks for index-only scans must be acquired at the page`
`246`		`- * level when the heap is not accessed, since tuple-level predicate`
`247`		`- * locks need the tuple's xmin value. If we had to visit the tuple`
`248`		`- * anyway, then we already have the tuple-level lock and can skip the`
`249`		`- * page lock.`
	`245`	`+ * If we didn't access the heap, then we'll need to take a predicate`
	`246`	`+ * lock explicitly, as if we had. For now we do that at page level.`
`250`	`247`	`*/`
`251`	`248`	`if (!tuple_from_heap)`
`252`	`249`	`PredicateLockPage(scandesc->heapRelation,`

Comments

(0)