NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit74b4d78

Amit Kapila

committed

Removal unused function parameter in CopyReadBinaryAttribute.

The function parameter column_no is not used in CopyReadBinaryAttribute,this can be removed.Commit0e319c7 removed the usage of column_no parameter in functionCopyReadBinaryAttribute but forgot to remove the parameter.Reported-by: Vignesh CAuthor: Vignesh CDiscussion:https://postgr.es/m/CALDaNm1TYSNTfqx_jfz9_mwEZ2Er=dZnu++duXpC1uQo1cG=WA@mail.gmail.com

1 parentae3259c commit74b4d78Copy full SHA for 74b4d78

File tree

1 file changed

-7

lines changed

src/backend/commands
- copy.c

1 file changed

-7

lines changed

`‎src/backend/commands/copy.c`

Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -367,8 +367,7 @@ static bool CopyReadLine(CopyState cstate);`
`367`	`367`	`staticboolCopyReadLineText(CopyStatecstate);`
`368`	`368`	`staticintCopyReadAttributesText(CopyStatecstate);`
`369`	`369`	`staticintCopyReadAttributesCSV(CopyStatecstate);`
`370`		`-staticDatumCopyReadBinaryAttribute(CopyStatecstate,`
`371`		`-intcolumn_no,FmgrInfo*flinfo,`
	`370`	`+staticDatumCopyReadBinaryAttribute(CopyStatecstate,FmgrInfo*flinfo,`
`372`	`371`	`Oidtypioparam,int32typmod,`
`373`	`372`	`bool*isnull);`
`374`	`373`	`staticvoidCopyAttributeOutText(CopyStatecstate,char*string);`
`@@ -3776,17 +3775,14 @@ NextCopyFrom(CopyState cstate, ExprContext *econtext,`
`3776`	`3775`	`errmsg("row field count is %d, expected %d",`
`3777`	`3776`	`(int)fld_count,attr_count)));`
`3778`	`3777`
`3779`		`-i=0;`
`3780`	`3778`	`foreach(cur,cstate->attnumlist)`
`3781`	`3779`	`{`
`3782`	`3780`	`intattnum=lfirst_int(cur);`
`3783`	`3781`	`intm=attnum-1;`
`3784`	`3782`	`Form_pg_attributeatt=TupleDescAttr(tupDesc,m);`
`3785`	`3783`
`3786`	`3784`	`cstate->cur_attname=NameStr(att->attname);`
`3787`		`-i++;`
`3788`	`3785`	`values[m]=CopyReadBinaryAttribute(cstate,`
`3789`		`-i,`
`3790`	`3786`	`&in_functions[m],`
`3791`	`3787`	`typioparams[m],`
`3792`	`3788`	`att->atttypmod,`
`@@ -4714,8 +4710,7 @@ CopyReadAttributesCSV(CopyState cstate)`
`4714`	`4710`	`* Read a binary attribute`
`4715`	`4711`	`*/`
`4716`	`4712`	`staticDatum`
`4717`		`-CopyReadBinaryAttribute(CopyStatecstate,`
`4718`		`-intcolumn_no,FmgrInfo*flinfo,`
	`4713`	`+CopyReadBinaryAttribute(CopyStatecstate,FmgrInfo*flinfo,`
`4719`	`4714`	`Oidtypioparam,int32typmod,`
`4720`	`4715`	`bool*isnull)`
`4721`	`4716`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit74b4d78

File tree

1 file changed

1 file changed

`‎src/backend/commands/copy.c`

0 commit comments