NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit747ca66

committed

Use "mb" not the nonexistent "rmb" for pg_read_barrier() on Alpha.

It's only necessary to fix this in 9.4; later versions don't have thiscode (because we ripped out Alpha support entirely), while earlier onesaren't actually using pg_read_barrier() anywhere.Per rather belated report from Christoph Berg.

1 parent3da9c06 commit747ca66Copy full SHA for 747ca66

File tree

1 file changed

-1

lines changed

src/include/storage
- barrier.h

1 file changed

-1

lines changed

`‎src/include/storage/barrier.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ extern slock_t dummy_spinlock;`
`117`	`117`	`* read barrier to cover that case. We might need to add that later.`
`118`	`118`	`*/`
`119`	`119`	`#definepg_memory_barrier()__asm__ __volatile__ ("mb" : : : "memory")`
`120`		`-#definepg_read_barrier()__asm__ __volatile__ ("rmb" : : : "memory")`
	`120`	`+#definepg_read_barrier()__asm__ __volatile__ ("mb" : : : "memory")`
`121`	`121`	`#definepg_write_barrier()__asm__ __volatile__ ("wmb" : : : "memory")`
`122`	`122`	`#elif defined(__hppa)\|\| defined(__hppa__)/* HP PA-RISC */`
`123`	`123`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit747ca66

File tree

1 file changed

1 file changed

`‎src/include/storage/barrier.h`

0 commit comments