Commit7431796

committed

fix_parsetree_attnums was not nearly smart enough about walking parse

trees. Also rewrite find_all_inheritors() in a more intelligible style.

1 parent549a8ba commit7431796Copy full SHA for 7431796

File tree

+158

-139

lines changed

+158

-139

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.59 1999/12/10 03:55:49 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.60 1999/12/14 03:35:20 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES`
`13`	`13`	`* The PortalExecutorHeapMemory crap needs to be eliminated`
`@@ -340,12 +340,11 @@ PerformAddAttribute(char *relationName,`
`340`	`340`	`{`
`341`	`341`	`if (inherits)`
`342`	`342`	`{`
`343`		`-Oidchildrelid;`
`344`	`343`	`List*child,`
`345`	`344`	`*children;`
`346`	`345`
`347`	`346`	`/* this routine is actually in the planner */`
`348`		`-children=find_all_inheritors(lconsi(myrelid,NIL),NIL);`
	`347`	`+children=find_all_inheritors(myrelid);`
`349`	`348`
`350`	`349`	`/*`
`351`	`350`	`* find_all_inheritors does the recursive search of the`
`@@ -354,7 +353,8 @@ PerformAddAttribute(char *relationName,`
`354`	`353`	`*/`
`355`	`354`	`foreach(child,children)`
`356`	`355`	`{`
`357`		`-childrelid=lfirsti(child);`
	`356`	`+Oidchildrelid=lfirsti(child);`
	`357`	`+`
`358`	`358`	`if (childrelid==myrelid)`
`359`	`359`	`continue;`
`360`	`360`	`rel=heap_open(childrelid,AccessExclusiveLock);`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/rename.c,v 1.37 1999/11/25 00:15:57 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/rename.c,v 1.38 1999/12/14 03:35:20 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -97,7 +97,7 @@ renameatt(char *relname,`
`97`	`97`	`*children;`
`98`	`98`
`99`	`99`	`/* this routine is actually in the planner */`
`100`		`-children=find_all_inheritors(lconsi(relid,NIL),NIL);`
	`100`	`+children=find_all_inheritors(relid);`
`101`	`101`
`102`	`102`	`/*`
`103`	`103`	`* find_all_inheritors does the recursive search of the`
`@@ -106,10 +106,9 @@ renameatt(char *relname,`
`106`	`106`	`*/`
`107`	`107`	`foreach(child,children)`
`108`	`108`	`{`
`109`		`-Oidchildrelid;`
	`109`	`+Oidchildrelid=lfirsti(child);`
`110`	`110`	`charchildname[NAMEDATALEN];`
`111`	`111`
`112`		`-childrelid=lfirsti(child);`
`113`	`112`	`if (childrelid==relid)`
`114`	`113`	`continue;`
`115`	`114`	`reltup=SearchSysCacheTuple(RELOID,`

Comments

(0)