forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit73b9952
committed
Improve pg_upgrade's report about failure to match up old and new tables.
Ordinarily, pg_upgrade shouldn't have any difficulty in matching up allthe relations it sees in the old and new databases. If it does, however,it just goes belly-up with a pretty unhelpful error message. That seemedfine as long as we expected the case never to occur in the wild, butAlvaro reported that it had been seen in a database whose pg_largeobjecttable had somehow acquired a TOAST table. That doesn't quite seem likea case that pg_upgrade actually needs to handle, but it would be good ifthe report were more diagnosable. Hence, extend the logic to print outas much information as we can about the mismatch(es) before we quit.In passing, improve the readability of get_rel_infos()'s data collectionquery, which had suffered seriously from lets-not-bother-to-update-commentssyndrome, and generally was unnecessarily disrespectful to readers.It could be argued that this is a bug fix, but given that we have so fewreports, I don't feel a need to back-patch; at least not before this hasbaked awhile in HEAD.1 parent06bd458 commit73b9952
2 files changed
+244
-141
lines changed0 commit comments
Comments
(0)