NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit734c057

committed

Add assertion in pgstat_write_statsfile() about processes allowed

This routine can currently only be called from the postmaster insingle-user mode or the checkpointer, but there was no sanity check tomake sure that this was always the case.This has proved to be useful when hacking the zone (at least to me), tomake sure that the write of the pgstats file happens at shutdown, aswanted by design, in the correct process context.Discussion:https://postgr.es/m/ZnEiqAITL-VgZDoY@paquier.xyz

1 parent63909da commit734c057Copy full SHA for 734c057

File tree

1 file changed

-0

lines changed

src/backend/utils/activity
- pgstat.c

1 file changed

-0

lines changed

`‎src/backend/utils/activity/pgstat.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1360,6 +1360,9 @@ pgstat_write_statsfile(void)`
`1360`	`1360`
`1361`	`1361`	`pgstat_assert_is_up();`
`1362`	`1362`
	`1363`	`+/* should be called only by the checkpointer or single user mode */`
	`1364`	`+Assert(!IsUnderPostmaster\|\|MyBackendType==B_CHECKPOINTER);`
	`1365`	`+`
`1363`	`1366`	`/* we're shutting down, so it's ok to just override this */`
`1364`	`1367`	`pgstat_fetch_consistency=PGSTAT_FETCH_CONSISTENCY_NONE;`
`1365`	`1368`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit734c057

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/pgstat.c`

0 commit comments