NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit733e49e

committed

Fix subtly-wrong volatility checking in BeginCopyFrom().

contain_volatile_functions() is best applied to the output ofexpression_planner(), not its input, so that insertion of functiondefault arguments and constant-folding have been done. (See commentsat CheckMutability, for instance.) It's perhaps unlikely that anyonewill notice a difference in practice, but still we should do it properly.In passing, change variable type from Node* to Expr* to reduce the netnumber of casts needed.Noted while perusing uses of contain_volatile_functions().

1 parent64f5962 commit733e49eCopy full SHA for 733e49e

File tree

1 file changed

-5

lines changed

src/backend/commands
- copy.c

1 file changed

-5

lines changed

`‎src/backend/commands/copy.c`

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2321,18 +2321,22 @@ BeginCopyFrom(Relation rel,`
`2321`	`2321`	`{`
`2322`	`2322`	`/* attribute is NOT to be copied from input */`
`2323`	`2323`	`/* use default value if one exists */`
`2324`		`-Node*defexpr=build_column_default(cstate->rel,attnum);`
	`2324`	`+Exprdefexpr= (Expr)build_column_default(cstate->rel,`
	`2325`	`+attnum);`
`2325`	`2326`
`2326`	`2327`	`if (defexpr!=NULL)`
`2327`	`2328`	`{`
`2328`		`-/* Initialize expressions in copycontext. */`
`2329`		`-defexprs[num_defaults]=ExecInitExpr(`
`2330`		`-expression_planner((Expr*)defexpr),NULL);`
	`2329`	`+/* Run the expression through planner */`
	`2330`	`+defexpr=expression_planner(defexpr);`
	`2331`	`+`
	`2332`	`+/* Initialize executable expression in copycontext */`
	`2333`	`+defexprs[num_defaults]=ExecInitExpr(defexpr,NULL);`
`2331`	`2334`	`defmap[num_defaults]=attnum-1;`
`2332`	`2335`	`num_defaults++;`
`2333`	`2336`
	`2337`	`+/* Check to see if we have any volatile expressions */`
`2334`	`2338`	`if (!volatile_defexprs)`
`2335`		`-volatile_defexprs=contain_volatile_functions(defexpr);`
	`2339`	`+volatile_defexprs=contain_volatile_functions((Node*)defexpr);`
`2336`	`2340`	`}`
`2337`	`2341`	`}`
`2338`	`2342`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit733e49e

File tree

1 file changed

1 file changed

`‎src/backend/commands/copy.c`

0 commit comments