NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit72ac4d7

committed

Correct type of front_pathkey to PathKey

In sort_inner_and_outer we iterate a list of PathKey elements, but thevariable is declared as (List *). This mistake is benign, because weonly pass the pointer to lcons() and never dereference it.This exists since ~2004, but it's confusing. So fix and backpatch to allsupported branches.Backpatch-through: 10Discussion:https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com

1 parenta192243 commit72ac4d7Copy full SHA for 72ac4d7

File tree

1 file changed

-1

lines changed

src/backend/optimizer/path
- joinpath.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/path/joinpath.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1243,7 +1243,7 @@ sort_inner_and_outer(PlannerInfo *root,`
`1243`	`1243`
`1244`	`1244`	`foreach(l,all_pathkeys)`
`1245`	`1245`	`{`
`1246`		`-Listfront_pathkey= (List)lfirst(l);`
	`1246`	`+PathKeyfront_pathkey= (PathKey)lfirst(l);`
`1247`	`1247`	`List*cur_mergeclauses;`
`1248`	`1248`	`List*outerkeys;`
`1249`	`1249`	`List*innerkeys;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit72ac4d7

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/joinpath.c‎`

0 commit comments