NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit72826fb

committed

Guard against incoming rowcount estimate of NaN in cost_mergejoin().

Although rowcount estimates really ought not be NaN, a bug elsewherecould perhaps result in that, and that would cause Assert failure incost_mergejoin, which I believe to be the explanation for bug #5977 fromAnton Kuznetsov. Seems like a good idea to expend a couple more cyclesto prevent that, even though the real bug is elsewhere. Not back-patching,though, because we don't encourage running production systems withAsserts on.

1 parentd5a7bf8 commit72826fbCopy full SHA for 72826fb

File tree

1 file changed

-3

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-3

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1704,10 +1704,10 @@ cost_mergejoin(MergePath path, PlannerInfo root, SpecialJoinInfo *sjinfo)`
`1704`	`1704`	`innerendsel;`
`1705`	`1705`	`Pathsort_path;/* dummy for result of cost_sort */`
`1706`	`1706`
`1707`		`-/* Protect some assumptions below that rowcounts aren't zero */`
`1708`		`-if (outer_path_rows <=0)`
	`1707`	`+/* Protect some assumptions below that rowcounts aren't zeroor NaN*/`
	`1708`	`+if (outer_path_rows <=0\|\|isnan(outer_path_rows))`
`1709`	`1709`	`outer_path_rows=1;`
`1710`		`-if (inner_path_rows <=0)`
	`1710`	`+if (inner_path_rows <=0\|\|isnan(inner_path_rows))`
`1711`	`1711`	`inner_path_rows=1;`
`1712`	`1712`
`1713`	`1713`	`if (!enable_mergejoin)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit72826fb

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments