NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit723acc9

committed

Must check indisready not just indisvalid when dumping from 9.2 server.

9.2 uses a kluge representation of "indislive"; we have to account forthat when examining pg_index. Simplest solution is to check indisreadyfor 9.0 and 9.1 as well; that's harmless though unnecessary, so it'snot worth making a version distinction for.Fixes oversight in commit683abc7,as noted by Andres Freund.

1 parenteb2a70f commit723acc9Copy full SHA for 723acc9

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4520,6 +4520,10 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4520`	`4520`	`resetPQExpBuffer(query);`
`4521`	`4521`	`if (fout->remoteVersion >=90000)`
`4522`	`4522`	`{`
	`4523`	`+/*`
	`4524`	`+ * the test on indisready is necessary in 9.2, and harmless in`
	`4525`	`+ * earlier/later versions`
	`4526`	`+ */`
`4523`	`4527`	`appendPQExpBuffer(query,`
`4524`	`4528`	`"SELECT t.tableoid, t.oid, "`
`4525`	`4529`	`"t.relname AS indexname, "`
`@@ -4540,7 +4544,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4540`	`4544`	`"i.indexrelid = c.conindid AND "`
`4541`	`4545`	`"c.contype IN ('p','u','x')) "`
`4542`	`4546`	`"WHERE i.indrelid = '%u'::pg_catalog.oid "`
`4543`		`-"AND i.indisvalid "`
	`4547`	`+"AND i.indisvalidAND i.indisready"`
`4544`	`4548`	`"ORDER BY indexname",`
`4545`	`4549`	`tbinfo->dobj.catId.oid);`
`4546`	`4550`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit723acc9

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c‎`

0 commit comments