NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit722548e

committed

Preserve caller's memory context in ProcessCompletedNotifies().

This is necessary to avoid long-term memory leakage, because the main loopin PostgresMain expects to be executing in MessageContext, and hence is abit sloppy about freeing stuff that is only needed for the duration ofprocessing the current client message. The known case of an actual leakis when encoding conversion has to be done on the incoming command string,but there might be others. Per report from Per-Olov Esgard.Back-patch to 9.0, where the bug was introduced by the LISTEN/NOTIFYrewrite.

1 parent0bd7305 commit722548eCopy full SHA for 722548e

File tree

1 file changed

-0

lines changed

src/backend/commands
- async.c

1 file changed

-0

lines changed

`‎src/backend/commands/async.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1090,6 +1090,7 @@ Exec_UnlistenAllCommit(void)`
`1090`	`1090`	`void`
`1091`	`1091`	`ProcessCompletedNotifies(void)`
`1092`	`1092`	`{`
	`1093`	`+MemoryContextcaller_context;`
`1093`	`1094`	`boolsignalled;`
`1094`	`1095`
`1095`	`1096`	`/* Nothing to do if we didn't send any notifications */`
`@@ -1103,6 +1104,12 @@ ProcessCompletedNotifies(void)`
`1103`	`1104`	`*/`
`1104`	`1105`	`backendHasSentNotifications= false;`
`1105`	`1106`
	`1107`	`+/*`
	`1108`	`+ * We must preserve the caller's memory context (probably MessageContext)`
	`1109`	`+ * across the transaction we do here.`
	`1110`	`+ */`
	`1111`	`+caller_context=CurrentMemoryContext;`
	`1112`	`+`
`1106`	`1113`	`if (Trace_notify)`
`1107`	`1114`	`elog(DEBUG1,"ProcessCompletedNotifies");`
`1108`	`1115`
`@@ -1135,6 +1142,8 @@ ProcessCompletedNotifies(void)`
`1135`	`1142`
`1136`	`1143`	`CommitTransactionCommand();`
`1137`	`1144`
	`1145`	`+MemoryContextSwitchTo(caller_context);`
	`1146`	`+`
`1138`	`1147`	`/* We don't need pq_flush() here since postgres.c will do one shortly */`
`1139`	`1148`	`}`
`1140`	`1149`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit722548e

File tree

1 file changed

1 file changed

`‎src/backend/commands/async.c`

0 commit comments